Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] account_invoice_inter_company: propagate invoice payment reference #727

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[13.0][IMP] account_invoice_inter_company: propagate invoice payment reference #727

merged 1 commit into from
Nov 28, 2024

Conversation

JordiMForgeFlow
Copy link
Contributor

No description provided.

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LauraCForgeFlow
LauraCForgeFlow approved these changes Nov 28, 2024
View reviewed changes
Copy link

@LauraCForgeFlow LauraCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Nov 28, 2024
Merged
Merged
Merged
Merged
@pedrobaeza
Copy link
Member

@carlos-lopez-tecnativa do you see it correct?

@pedrobaeza
Copy link
Member

@JordiMForgeFlow next time, before doing all the fw-ports, wait for the first one to be merged, as if any change, now you have to propagate that change to all the opened PRs, multiplying the work.

carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Nov 28, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordiMForgeFlow
Copy link
Contributor Author

@pedrobaeza I know, but as it was a clear change to me and I had to start focusing on other work I wanted to have them prepared before hand :)

@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 28, 2024
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-727-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 79a9e39 into OCA:13.0 Nov 28, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c48386e. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-imp-account_invoice_inter_company-payment_ref branch November 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@LauraCForgeFlow LauraCForgeFlow LauraCForgeFlow approved these changes

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
8 participants
@JordiMForgeFlow @pedrobaeza @OCA-git-bot @AaronHForgeFlow @LoisRForgeFlow @GuillemCForgeFlow @LauraCForgeFlow @carlos-lopez-tecnativa