purchase_sale_inter_company: fix validation of several picking. self can have more than one record #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renda-dev
approved these changes
Oct 23, 2023
|
@sebastienbeau since we put some effort in writing tests for #507 , can I ask you to increase coverage for this fix too? Thank you! |
MiquelRForgeFlow
approved these changes
Oct 26, 2023
67bbdf0 to
224cdc5
Compare
|
@francesco-ooops, I have added the test and done a rebase, it's should be ready for the merge, it's ok for you ? |
…can have more than one record
224cdc5 to
10f1712
Compare
|
This PR has the |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 91f12da. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to validate more then one picking.
It will raise an error.
Refactor the code to fix the incompatibility, and clean it to make it simplier and more readable
Fix pr : #507