[16.0][MIG] product_multi_company #459

atchuthan · 2023-03-14T06:43:36Z

yajo · 2023-09-12T07:44:27Z

product_multi_company/models/product_product.py

+    company_ids = fields.Many2many(
+        string="Companies",
+        comodel_name="res.company",
+        default=lambda self: self._default_company_ids(),
+    )
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        """Ensure the template initially has the same companies as the variant."""
+        for values in vals_list:
+            if not values.get("company_ids") and values.get("product_tmpl_id"):
+                values["company_ids"] = [
+                    (
+                        6,
+                        0,
+                        self.env["product.template"]
+                        .browse(values.get("product_tmpl_id"))
+                        .company_ids.ids,
+                    )
+                ]
+        res = super(ProductProduct, self).create(vals_list)
+        if "from_create_variants" not in self._context:
+            res.product_tmpl_id.write({"company_ids": [(6, 0, res.company_ids.ids)]})
+        return res
+
+    def write(self, values):
+        """Ensure the template's companies are a superset of the variant's."""
+        if self.env.context.get("company_inverse"):
+            return super(ProductProduct, self).write(values)
+        if values.get("company_ids") and values["company_ids"][0][0] == 6:
+            # Add companies to the template, but don't remove them.
+            companies_to_add = list(
+                set(values.get("company_ids")[0][2]).difference(self.company_ids.ids)
+            )
+            companies_to_add.extend(self.product_tmpl_id.company_ids.ids)
+            if companies_to_add:
+                self.product_tmpl_id.write({"company_ids": [(6, 0, companies_to_add)]})
+        return super(ProductProduct, self).write(values)


All this code doesn't exist in the previous branch. Actually, there was no product_product.py file. Only a small product_template.py:

https://github.com/OCA/multi-company/tree/ae4570d4f327ce5e0ad3779bbcde3369b82c3acb/product_multi_company/models

I observe also that in the commit 9633be1, labeled [MIG] product_multi_company: black, isort, prettier, you're not actually just passing the automated pre-commit reformats. You're refactoring the module completely.

Most of the logic you add there should be unnecessary at first sight, as it should exist already in the inherited multi.company.abstract model.

I'm confused. Why did you have to refactor the module? Didn't the abstract model work? Why did you hide these big changes in the reformat commit?

@yajo

In v13, they added those extra changes to avoid the below error.
#252
And it is still happening in the latest v15 code.

Detailed info regarding the issues is in the below link
#264

We are having the same issue in migrated code too.

I think we need to add those back.

Thanks

@yajo
Creating a related stored company_ids field on the product.product solves this issue.
Shall we go with this instead of having those all changes from v13?
I can't think of any disadvantages with this method.

========================================== Product permissions for discrete companies ========================================== This modules allows to select in which of the companies you want to use each of the products. Installation ============ This module uses the post and uninstall hooks for updating default product template security rule. This only means that updating the module will not restore the security rule this module changes. Only a complete removal and reinstallation will serve. Usage ===== On the product form view, go to the "Information" tab, and put the companies in which you want to use that product. If none is selected, the product will be visible in all of them. The default value is the current one.

* Rename manifest * Change openerp references to odoo * Bump version * Add pragma no cover * Edit security of product employee to allow writes (in tests) * Fix permissions in tests * Fix domain & add test * Implement base_multi_company on product_multi_company * Add related cols for product variant

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-product_multi_company/

amkarthik · 2023-09-27T13:13:21Z

@yajo
We used 13.0 branch during our migration as it contain more commits than previous.
And we tested by migrating the previous branch and it looks those changes in 13.0 is not needed any more.
We will contribute it ASAP

Thanks!

yajo · 2023-09-28T06:52:35Z

At this point, it will probably be easier to just restart migrating from 15.0.

amkarthik · 2023-10-03T07:52:15Z

@yajo

We are finished with the work. Please check again.

Thanks!

yajo · 2023-10-20T09:05:49Z

product_multi_company/tests/test_product_multi_company.py

-        company = self.env.company
-        self.assertTrue(company.id in product.company_ids.ids)
+        self.assertFalse(product.company_ids)


issue: wrong test fix.

This test was checking that the current company was added to product.company_ids. That's exactly the purpose of this module.

If you commit this change and the tests go ✔️, it means that something's not working properly in the module. Instead, probably you should undo this change and actually fix the module.

@yajo
We will check on it.
Have you had a chance to look into this comments?
#459 (comment)
#459 (comment)

Please review and let us know your feedback, that will be very helpful.

Thanks

issue: wrong test fix.

This test was checking that the current company was added to product.company_ids. That's exactly the purpose of this module.

If you commit this change and the tests go ✔️, it means that something's not working properly in the module. Instead, probably you should undo this change and actually fix the module.

We have removed the default value from the company_ids fields.
Please review this link
https://github.com/OCA/multi-company/pull/458/files#diff-768c66d1106f5fdcb827fc104212e9b76a2739fae84f770ffe2687ec3bea1c4bR19

And this is to support the statement that if a product doesn't have any companies set then it is shared by all the company.

I think we just need to rename the test method name. Correct me If I misunderstood something.

Thanks

Shide · 2023-12-15T16:42:11Z

Tests still failing

legalsylvain · 2023-12-17T11:31:42Z

/ocabot migration product_multi_company

amkarthik · 2023-12-18T07:37:45Z

@Shide
The reason for the error is #459 (comment)
The suggested fix in v16 is #459 (comment)
I would like to have your thoughts on the fix.
cc: @yajo

pilarvargas-tecnativa · 2024-05-23T09:20:46Z

Superseed by #628

amkarthik approved these changes Apr 20, 2023

View reviewed changes

SodexisTeam force-pushed the 16.0-mig-product_multi_company branch from 2a652e9 to adfd3b0 Compare April 20, 2023 08:02

amkarthik mentioned this pull request Apr 21, 2023

Migration to version 16.0 #388

Open

20 tasks

SodexisTeam force-pushed the 16.0-mig-product_multi_company branch 3 times, most recently from f8d9673 to 7094739 Compare April 24, 2023 13:49

SodexisTeam force-pushed the 16.0-mig-product_multi_company branch 3 times, most recently from cd71b94 to 5be65d8 Compare July 26, 2023 10:25

yajo suggested changes Sep 12, 2023

View reviewed changes

pedrobaeza and others added 20 commits September 26, 2023 13:43

product_multi_company: Migration to 9.0

55836a9

OCA Transbot updated translations from Transifex

74f6f43

OCA Transbot updated translations from Transifex

50a9c74

[MIG] *_multi_company: OpenUpgrade migration scripts

c8956d6

OCA Transbot updated translations from Transifex

7a3c40a

[MIG] product_multi_company: Migration to 11.0

fb23ce9

[UPD] Update product_multi_company.pot

b3f92e0

[MIG] product_multi_company: Remove migration scripts

c1f729c

Migrate product_multi_company to version 12

c0d73b6

Fix product_multi_company description

0c03d88

[UPD] Update product_multi_company.pot

00e8b00

[UPD] README.rst

d4a042c

[IMP] product_multi_company: black, isort, prettier

b7604ab

[MIG] product_multi_company: Migration to 13.0

db6281a

[MIG]product_multi_company: Migration to 13.0 (continue)

bac1c28

[UPD] Update product_multi_company.pot

c135a46

JasminSForgeFlow and others added 5 commits September 26, 2023 13:43

[MIG] product_multi_company: Migration to 15.0

8266140

[UPD] Update product_multi_company.pot

4ad205e

[UPD] README.rst

9bf5d2f

[UPD] README.rst

f4388f1

[MIG] product_multi_company: black, isort, prettier

55ebf5b

SodexisTeam force-pushed the 16.0-mig-product_multi_company branch 2 times, most recently from 2ad1ce2 to 7d4068d Compare October 3, 2023 07:25

yajo suggested changes Oct 20, 2023

View reviewed changes

amkarthik force-pushed the 16.0-mig-product_multi_company branch from 7d4068d to 5fb53a3 Compare December 6, 2023 08:25

andrel-exo referenced this pull request Dec 11, 2023

[MIG] base_multi_company: Migration to 16.0

91088f1

andrel-exo mentioned this pull request Dec 11, 2023

[16.0] Error in Domain Regardless of company_ids Field State #545

Closed

legalsylvain added the needs fixing label Dec 16, 2023

OCA-git-bot added this to the 16.0 milestone Dec 17, 2023

amkarthik force-pushed the 16.0-mig-product_multi_company branch from 5fb53a3 to 24e9503 Compare December 18, 2023 07:32

SirAionTech mentioned this pull request Dec 19, 2023

[ADD] inherit_company modules #554

Open

amkarthik force-pushed the 16.0-mig-product_multi_company branch from 24e9503 to 0ede9b3 Compare December 27, 2023 11:19

amkarthik force-pushed the 16.0-mig-product_multi_company branch from 0ede9b3 to d8e1d26 Compare January 4, 2024 08:17

[MIG] product_multi_company: Migration to 16.0

5bde459

amkarthik force-pushed the 16.0-mig-product_multi_company branch from d8e1d26 to 5bde459 Compare January 4, 2024 08:27

Kev-Roche mentioned this pull request Apr 8, 2024

[16.0][MIG] product_supplierinfo_intercompany_multi_company #609

Closed

micheledic approved these changes Apr 17, 2024

View reviewed changes

pilarvargas-tecnativa mentioned this pull request May 23, 2024

[16.0][MIG] product_multi_company: Migration to version 16.0 #628

Merged

pedrobaeza closed this May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_multi_company #459

[16.0][MIG] product_multi_company #459

atchuthan commented Mar 14, 2023

yajo Sep 12, 2023

amkarthik Oct 19, 2023

amkarthik Oct 19, 2023

amkarthik commented Sep 27, 2023

yajo commented Sep 28, 2023

amkarthik commented Oct 3, 2023

yajo Oct 20, 2023

amkarthik Oct 20, 2023

amkarthik Oct 20, 2023

Shide commented Dec 15, 2023

legalsylvain commented Dec 17, 2023

amkarthik commented Dec 18, 2023

pilarvargas-tecnativa commented May 23, 2024

[16.0][MIG] product_multi_company #459

[16.0][MIG] product_multi_company #459

Conversation

atchuthan commented Mar 14, 2023

yajo Sep 12, 2023

Choose a reason for hiding this comment

amkarthik Oct 19, 2023

Choose a reason for hiding this comment

amkarthik Oct 19, 2023

Choose a reason for hiding this comment

amkarthik commented Sep 27, 2023

yajo commented Sep 28, 2023

amkarthik commented Oct 3, 2023

yajo Oct 20, 2023

Choose a reason for hiding this comment

amkarthik Oct 20, 2023

Choose a reason for hiding this comment

amkarthik Oct 20, 2023

Choose a reason for hiding this comment

Shide commented Dec 15, 2023

legalsylvain commented Dec 17, 2023

amkarthik commented Dec 18, 2023

pilarvargas-tecnativa commented May 23, 2024