-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- adds a base64url format description #3184
Conversation
@baywet I think you need to update this to remove the deprecated version info. I'm also wondering if, now that we have definitively settled on |
Can you expand on why do you think we should remove the deprecated aspect please? I might have missed part of the conversation here. If it were only up to me, byte would be base64 and base64url would be base64url. byte only being an alias to byte64 for compatibility reasons. Those different names are simply adding confusion IMHO. |
Edit to my previous comment: formats are kebab-case so Re: In #3174 I suggested having a |
c83d732
to
50380dc
Compare
@handrews so are we good with this PR as is or do you suggest we make other changes? |
I'm still feeling meh about whether to use @MikeRalphson, @darrelmiller, anyone else - any preference for |
+1 for base64url, let's not be held back by our past missteps. |
@MikeRalphson thanks - in that case this looks good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related #3167