Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename namespace of GameFinder handler replacements #15

Closed
Nutzzz opened this issue Feb 14, 2024 · 1 comment
Closed

Rename namespace of GameFinder handler replacements #15

Nutzzz opened this issue Feb 14, 2024 · 1 comment
Assignees
@Nutzzz
Labels
enhancement New feature or request

Comments

@Nutzzz
Copy link
Owner

Nutzzz commented Feb 14, 2024

Retaining the old filenames is important for upstream compatibility, but even if these are theoretically supposed to operate as drop-in replacements, it doesn't hurt much to change the namespace to prevent confusion.
Nutzzz added a commit that referenced this issue Feb 14, 2024
@Nutzzz
Update GameFinder namespaces
b0978df 
See #15
Nutzzz added a commit that referenced this issue Feb 14, 2024
@Nutzzz
Update GameFinder namespaces
e916b25 
See #15
Nutzzz added a commit that referenced this issue Feb 14, 2024
@Nutzzz
Update GameFinder namespaces
7d18706 
See #15
Nutzzz added a commit that referenced this issue Feb 14, 2024
@Nutzzz
Update GameFinder namespaces
261021c 
See #15
@Nutzzz Nutzzz closed this as completed Feb 14, 2024
@Nutzzz Nutzzz added the enhancement New feature or request label Feb 16, 2024
Nutzzz added a commit that referenced this issue Feb 24, 2024
@Nutzzz
Warn about errors related to Oculus service
6b224d8 
See #15
Also decrease connection timeout and move service utils to GameCollector.Common
@Nutzzz
Copy link
Owner Author

Nutzzz commented Jun 28, 2024

Note 6b224d8 fixes #17, not this issue.

@Nutzzz Nutzzz self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nutzzz Nutzzz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nutzzz