Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'core' import, only allowing importing from 'ember-resources' #1090

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove the 'core' import, only allowing importing from 'ember-resources' #1090

merged 1 commit into from
Jan 9, 2024

Conversation

NullVoxPopuli
Copy link
Owner

No description provided.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 19.14 kB 4.22 kB 1.55 kB 1.36 kB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Preview URLs

readme: https://c64014cb.ember-resources.pages.dev
api docs: https://c64014cb.ember-resources.pages.dev/modules.html

@NullVoxPopuli NullVoxPopuli merged commit 837ee4f into main Jan 9, 2024
26 checks passed
@NullVoxPopuli NullVoxPopuli deleted the only-allow-the-root-import branch January 9, 2024 18:49
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NullVoxPopuli