Wrap declarations when including from C++ #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Previously, one had to remember to always include SDK
headers from a C++ translation unit like this:
Which arguably is a bit tedious and errorprone. And when leaving those
out it's perhaps not entirely obvious to beginners why they are getting
weird linker errors.
This commit thus wraps all the SDK API headers inside appropriate guards
using with the following macros
such that a C++ translation can include them simply via e.g.:
Note that this pattern follows what other libraries such as the Glibc,
Glib or GSL do with their headers.