Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best practice to Package-Versioning.md #3353

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

ericstj
Copy link
Contributor

@ericstj ericstj commented Nov 13, 2024

@ericstj ericstj requested review from a team as code owners November 13, 2024 16:59
Copy link

Learn Build status updates of commit 770f5ab:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Package-Versioning.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@aortiz-msft aortiz-msft self-requested a review November 13, 2024 19:14
docs/concepts/Package-Versioning.md Outdated Show resolved Hide resolved
@nkolev92 nkolev92 requested a review from aortiz-msft December 4, 2024 01:23
@nkolev92
Copy link
Member

nkolev92 commented Dec 4, 2024

@aortiz-msft

Can you please take another look.

I've made pushed a change to the line above so we can complete this PR.

Copy link

Learn Build status updates of commit 3dcb150:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Package-Versioning.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@nkolev92
Copy link
Member

I've dismissed the stale review so I can merge this, but we can make edits on top of it @aortiz-msft thinks we need them.

@nkolev92 nkolev92 merged commit 6728686 into NuGet:main Dec 10, 2024
2 checks passed
jgonz120 added a commit that referenced this pull request Jan 21, 2025
* Add best practice to Package-Versioning.md (#3353)

* Update Nu1302 documentation with more information (#3363)

* Update NuGet-6.12 Release Notes for 6.12.3 (#3378)

* Adding No README chapter (#3381)

* Adding No README chapter

* Minor update

* Updated text to address review comments

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Nigusu Solomon Yenework <59111203+Nigusu-Allehu@users.noreply.github.com>
Co-authored-by: Donnie Goodson <49205731+donnie-msft@users.noreply.github.com>
Co-authored-by: Olia Gavrysh <31997351+OliaG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants