Add the NETSdkVersion to restore telemetry #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Jan 7, 2025
zivkan
approved these changes
Jan 7, 2025
martinrrm
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3075
Description
Per the conversation in the issue, we need the NETSdkVersion to reason about usage of SdkAnalysisLevel and global.json for pinning the SDK version to previous behavior.
We're adding it to the ProjectRestoreSettings which are settings that are not part of the hashing since they don't really influence the restore behavior.
Note that the population of this property is only done in the SDK projects case in Visual Studio, since that's the only place where the data is relevant. We don't need it on the commandline in any scenario.
This PR is accompanied by dotnet/project-system#9627.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.