-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add review comment to sb files #5196
Conversation
You can really @ that team from the nuget org. @dotnet/source-build-internal doesn't do anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/source-build-internal cannot be referenced from the nuget org.
Thanks for noticing, will think of some better way to handle this |
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
b7556d1
to
f08c15a
Compare
@nkolev92 apologies for taking longer to resolve the issue mentioned. We opted to simply including particular contributors in the review request instead of the team alias that is not available in the org |
@nkolev92 thanks for the review, unfortunately I don't have the write access to merge the PR. Could you please merge it? Thank you! |
Bug
Fixes:
Regression? Last working version:
Description
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter
SourceBuild*
files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation