Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add review comment to sb files #5196

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

oleksandr-didyk
Copy link
Contributor

Bug

Fixes:

Regression? Last working version:

Description

Contributes to dotnet/source-build#3435

Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@oleksandr-didyk oleksandr-didyk requested a review from a team as a code owner June 1, 2023 15:28
@ghost ghost added the Community PRs created by someone not in the NuGet team label Jun 1, 2023
jeffkl
jeffkl previously approved these changes Jun 5, 2023
@nkolev92
Copy link
Member

nkolev92 commented Jun 5, 2023

You can really @ that team from the nuget org.

@dotnet/source-build-internal doesn't do anything.

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/source-build-internal cannot be referenced from the nuget org.

@oleksandr-didyk
Copy link
Contributor Author

@dotnet/source-build-internal cannot be referenced from the nuget org.

Thanks for noticing, will think of some better way to handle this

@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Jun 13, 2023
@ghost
Copy link

ghost commented Jun 13, 2023

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@oleksandr-didyk oleksandr-didyk force-pushed the add-sb-review-comment branch from b7556d1 to f08c15a Compare June 15, 2023 14:43
@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Jun 15, 2023
@oleksandr-didyk
Copy link
Contributor Author

@nkolev92 apologies for taking longer to resolve the issue mentioned. We opted to simply including particular contributors in the review request instead of the team alias that is not available in the org

@oleksandr-didyk
Copy link
Contributor Author

@nkolev92 thanks for the review, unfortunately I don't have the write access to merge the PR. Could you please merge it? Thank you!

@jeffkl jeffkl merged commit f1e67ed into NuGet:dev Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants