Remove netstandard2.0 and netcoreapp3.1 legs for projects that only work as distribution vehicles, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Commandline.Xplat and Microsoft.Build.NugetSdkResolver #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Mar 17, 2023
zivkan
approved these changes
Mar 20, 2023
This was referenced Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12489
Regression? Last working version:
Description
These projects are only used as distribution vehicles for building the .NET SDK. We don't really need all the frameworks in there.
I have removed 4 of these frameworks + their respective test projects.
This removes 10 build/restore legs, speeding up our build and removing the # of tests we have.
I didn't go as far as NuGet/Home#9886. One change at a time :)
Here are the before and after of frameworks. I'm only including the deltas. Note that I checked the dotnet build from source as well.
Before:
Microsoft.Build.NuGetSdkResolver.csproj = net472;netstandard2.0;netcoreapp5.0
NuGet.Build.Tasks.Console.csproj = net472;netcoreapp3.1;netcoreapp5.0
NuGet.Build.Tasks.csproj = net472;netstandard2.0;netcoreapp5.0
NuGet.CommandLine.XPlat.csproj = net472;netcoreapp3.1;netcoreapp5.0
NuGet.XPlat.FuncTest.csproj = net472;netcoreapp3.1;netcoreapp5.0
Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
NuGet.Build.Tasks.Console.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
NuGet.Build.Tasks.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
NuGet.CommandLine.Xplat.Tests.csproj = net472;netcoreapp3.1;netcoreapp5.0
After:
Microsoft.Build.NuGetSdkResolver.csproj = net472;netcoreapp5.0
NuGet.Build.Tasks.Console.csproj = net472;netcoreapp5.0
NuGet.Build.Tasks.csproj = net472;netcoreapp5.0
NuGet.CommandLine.XPlat.csproj = net472;netcoreapp5.
NuGet.XPlat.FuncTest.csproj = net472;netcoreapp5.0
Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;netcoreapp5.0
NuGet.Build.Tasks.Console.Test.csproj = net472;netcoreapp5.0
NuGet.Build.Tasks.Test.csproj = net472;netcoreapp5.0
NuGet.CommandLine.Xplat.Tests.csproj = net472;netcoreapp5.0
DotnetBuildFromSource="true"
Before:
NuGet.XPlat.FuncTest.csproj = net472;net7.0;net7.0
Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;net7.0;net7.0
NuGet.Build.Tasks.Console.Test.csproj = net472;net7.0;net7.0
NuGet.Build.Tasks.Test.csproj = net472;net7.0;net7.0
NuGet.CommandLine.Xplat.Tests.csproj = net472;net7.0;net7.0
Microsoft.Build.NuGetSdkResolver.csproj = net7.0;netstandard2.0;net7.0
NuGet.Build.Tasks.Console.csproj = net472;net7.0;net7.0
NuGet.Build.Tasks.csproj = net7.0;netstandard2.0;net7.0
NuGet.CommandLine.XPlat.csproj = net472;net7.0;net7.0
After:
NuGet.XPlat.FuncTest.csproj = net472;netcoreapp5.0;net7.0
Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;netcoreapp5.0;net7.0
NuGet.Build.Tasks.Console.Test.csproj = net472;netcoreapp5.0;net7.0
NuGet.Build.Tasks.Test.csproj = net472;netcoreapp5.0;net7.0
NuGet.CommandLine.Xplat.Tests.csproj = net472;netcoreapp5.0;net7.0
Microsoft.Build.NuGetSdkResolver.csproj = net472;netcoreapp5.0;net7.0
NuGet.Build.Tasks.Console.csproj = net472;netcoreapp5.0;net7.0
NuGet.Build.Tasks.csproj = net472;netcoreapp5.0;net7.0
NuGet.CommandLine.XPlat.csproj = net472;netcoreapp5.0;net7.0
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation