Test: enable signature verification on Linux CI machines #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E and Apex tests are failing for unrelated reasons. This change does not impact those tests. |
|
Woo-hoo! I got PR #5000! |
erdembayar
previously approved these changes
Jan 10, 2023
6e190a4 to
8589785
Compare
|
@erdembayar, I also enabled signature verification in source build and re-enabled a few signing/verification tests on Linux. Thanks for the feedback! |
erdembayar
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12357, NuGet/Home#11892
Regression? Last working version: N/A
Description
This change enables signed package verification by default on our Linux CI machines. Since we're already using .NET 7 SDK, we should enable signed package verification on Linux by default.
This change also bumps source build's .NET SDK version from 7.0.100-preview.6.22352.1 to 7.0.100 because the necessary .NET SDK support for verifying signed packages on Linux first appeared in .NET 7.0.100 SDK (GA).
This PR introduces no behavioral changes to the product itself.
CC @aortiz-msft, @skofman1
FYI @dotnet/source-build-internal, @lbussell for source build-related changes
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation