-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Penalty classes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 97.50% 98.54% +1.04%
==========================================
Files 40 49 +9
Lines 1680 1858 +178
==========================================
+ Hits 1638 1831 +193
+ Misses 42 27 -15 ☔ View full report in Codecov by Sentry. |
Deal with defaults outside this function. Too complicated.
Inherited from base interval scorer
Useful to have access to fitable object utilities like is_fitted and check_is_fitted
Enables different number of variables in base_values and input data to fit
… MVCAPA + align with CAPA
The output is now 2d, but was 1d before
Other checks should ensure that the input will always be correct
The <= condition passes all tests, while < don't
It is inherited from BaseEstimator
None means fitting is required, and min_size == 1 will never require fitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
penalty
,penalty_scale
orthreshold_scale
topenalty
throughout.compose
module with thePenalisedScore
class. For now only used byCAPA
andMVCAPA
.