Inherit from BaseEstimator #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is leaner than BaseTransformer, and more flexible and stable.
Use inner type DataFrame such that .index and .column always exists, despite input being Series or ndarray
Not needed for detectors really. And predict and transform do the same thing, but differs in output format, so transform should have the same signature as predict
This was referenced Sep 4, 2024
Closed
sktime 0.33 fixes sktime/sktime#7067. Allows BaseDetector to inherit from BaseEstimator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 96.28% 96.30% +0.02%
==========================================
Files 34 34
Lines 1453 1462 +9
==========================================
+ Hits 1399 1408 +9
Misses 54 54 ☔ View full report in Codecov by Sentry. |
To improve test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_inheritanceto be more lenient to framework level extensions sktime/sktime#7067