Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shortcuts modal layout & look #961

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

KievDevel
Copy link
Contributor

@KievDevel KievDevel commented Jan 8, 2025

BEFORE:

image

AFTER:

image

@ketile
Copy link

ketile commented Jan 8, 2025

The change to default dialog looks good.

In my opinion we should keep the horizontal dividers and the extra vertical spacing from the original. The original left/right alignment of title and icon should also be kept. These changes will make the list look less cluttered.

Copy link
Contributor

@datenreisender datenreisender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Ketil on the stylistic aspects. The technical aspects are fine.

@KievDevel
Copy link
Contributor Author

KievDevel commented Jan 14, 2025

@ketile reason for the first implementation is that I don't like distance between label and button shortcuts, it feels too far away with decreased ability to quickly read :( I agree that this way it looks cleaner
Here is an updated version based on the comments:

image

@ketile
Copy link

ketile commented Jan 15, 2025

I recommend removing the colons. Might also use a more narrow version of the dialog if one exists.

@KievDevel
Copy link
Contributor Author

This was my first attempt, but existing modal is too narrow. Something in between would be perfect, but I didn't want to create another option of the modal for the single use case

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants