-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shortcuts modal layout & look #961
base: main
Are you sure you want to change the base?
Conversation
The change to default dialog looks good. In my opinion we should keep the horizontal dividers and the extra vertical spacing from the original. The original left/right alignment of title and icon should also be kept. These changes will make the list look less cluttered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Ketil on the stylistic aspects. The technical aspects are fine.
@ketile reason for the first implementation is that I don't like distance between label and button shortcuts, it feels too far away with decreased ability to quickly read :( I agree that this way it looks cleaner |
I recommend removing the colons. Might also use a more narrow version of the dialog if one exists. |
BEFORE:
AFTER: