Remove UIs for configuring voltage for GPIO Ports 1,2 and 7 for nRF54H20 DK (PCA10175) #151
Conversation
|
Add labels:
For UI review:
|
| "boardRevision": "1.0.0", | ||
| "boardName": "nRF54H20 DK v1.0.0" |
There was a problem hiding this comment.
1.0.0 is an assumption.
Not updating current 0.7.0 definition file https://github.com/NordicSemiconductor/pc-nrfconnect-board-configurator/blob/main/src/common/boards/nrf_PCA10175_0.7.0_54H20.json
There was a problem hiding this comment.
UPD. New config should be for all devices
| "pmicPorts": [ | ||
| { | ||
| "type": "voltage", | ||
| "port": 1, |
There was a problem hiding this comment.
was port: 2, but I assume this is just an index property?
There was a problem hiding this comment.
Port number refers to actual port in the PMIC, and is not arbitrary. Changing port here will alter another output on the PMIC.
There was a problem hiding this comment.
It says to remove controls for ports 1,2 and 7.
As for ports numbers we have only 1-4 range, I've removed controls based on their descriptions as that might be what user see. Is that correct?
For the port property will return 2 number
There was a problem hiding this comment.
The GPIO ports are "groups" of electronic pins on the target microcontroller (54H20) itself. The port number here is the output on the power management chip (supplying different voltages to the 54H20 which is, in turn, used to power the GPIO ports).
To find out which PMIC port we need to hide, we need to look into the HW design of the DK:
https://nordicsemi.atlassian.net/wiki/spaces/APPS/pages/67295432/nRF5340+Board+Controller+-+1.6+nRF5340+Pinout#nRF54H20-DK
From the table, it looks like only port 2 (GPIO port 9) should be configurable, leaving the three other IO ports out.
This means we should have only port 2 in the definition file.
| "state": true | ||
| } | ||
| ], | ||
| "pmicPorts": [ |
There was a problem hiding this comment.
other ports were removed from here as well
| "pmicPorts": [ | ||
| { | ||
| "type": "voltage", | ||
| "port": 1, |
There was a problem hiding this comment.
Port number refers to actual port in the PMIC, and is not arbitrary. Changing port here will alter another output on the PMIC.
| @@ -86,7 +89,13 @@ export function getBoardDefinition( | |||
|
|
|||
| case 'PCA10175': | |||
| // nRF54H20 | |||
| return { boardControllerConfigDefinition: typednrf54h20v070json }; | |||
| if (boardRevision === '0.7.0') { | |||
There was a problem hiding this comment.
I suspect there might be more versions than 0.7.0. We should have a look around to see which DPKs are available. (Otherwise the new file will be default for all otheer H20s (which might be fine, altogether)
There was a problem hiding this comment.
True. Thought that is something to check closer to the date when merge is required
.
Same for the version as it is totally guessed now
No description provided.