Show actual ip address of the user #734

gbaranski · 2025-01-08T13:14:48Z

solved by calling the insights API, and displaying the ip from the insights data

core/models.go

daemon/job_actual_ip.go

daemon/jobs.go

daemon/job_actual_ip.go

daemon/jobs.go

daemon/job_actual_ip.go

daemon/actual_ip_resolver.go

gbaranski added 3 commits January 8, 2025 14:12

add missing ip field in Insights

65dc7d9

update insights data on connect

38f861a

use ip from insights data for rpc_status

334ee8f

gbaranski requested a review from mariusSincovici January 8, 2025 13:14

keliramu reviewed Jan 8, 2025

View reviewed changes

core/models.go Outdated Show resolved Hide resolved

keliramu changed the title ~~show actual ip address of the user~~ Show actual ip address of the user Jan 9, 2025

job_actual_ip and actualIP in DataManager

3b24e3a

gbaranski temporarily deployed to Internal January 9, 2025 11:51 — with GitHub Actions Inactive

gbaranski requested a review from keliramu January 9, 2025 11:51

gbaranski added 3 commits January 9, 2025 17:42

remove time.Sleep that was used for testing

3f5e1a1

on disconnect, don't spawn a new goroutine

d994c3f

no context cancellation in case of other events

7041597

gbaranski temporarily deployed to Internal January 9, 2025 16:51 — with GitHub Actions Inactive

fix confusion of && and ||

557ef1d

gbaranski temporarily deployed to Internal January 9, 2025 16:56 — with GitHub Actions Inactive

devzbysiu reviewed Jan 10, 2025

View reviewed changes

daemon/jobs.go Outdated Show resolved Hide resolved

daemon/job_actual_ip.go Outdated Show resolved Hide resolved

fix incorrect use of switch

a0bde68

gbaranski temporarily deployed to Internal January 10, 2025 08:52 — with GitHub Actions Inactive

gbaranski added 4 commits January 10, 2025 11:06

insightsUntilSuccess -> insightsIPUntilSuccess

2521a58

fix: remove trailing newline

b6ba8d0

feat: add InsightsViaTunnel()

5c02879

feat: log error for actualIP()

6c594e1

gbaranski temporarily deployed to Internal January 13, 2025 09:21 — with GitHub Actions Inactive

gbaranski added 2 commits January 13, 2025 10:23

fix: mispelling of necessary

c2d42db

fix: make requests via api.doWithClient()

d6c50d6

gbaranski temporarily deployed to Internal January 13, 2025 10:11 — with GitHub Actions Inactive

style: remove trailing newline

0b0fb1a

gbaranski temporarily deployed to Internal January 13, 2025 11:03 — with GitHub Actions Inactive

fix: make to actually use InsightsViaTunnel

341aeb7

mariusSincovici reviewed Jan 20, 2025

View reviewed changes

refactor: move JobActualIP out of jobs

07956a2

gbaranski temporarily deployed to Internal January 22, 2025 12:12 — with GitHub Actions Inactive

gbaranski added 2 commits January 22, 2025 13:16

refactor: ActualIP -> ActualIPResolver

f2aa444

fix: handle context cancellation

e4171da

gbaranski temporarily deployed to Internal January 22, 2025 12:17 — with GitHub Actions Inactive

gbaranski added 2 commits January 23, 2025 10:49

refactor: now call new fn name

bda07b3

fix: cleaner behaviour of update fn

10fc237

gbaranski temporarily deployed to Internal January 23, 2025 09:49 — with GitHub Actions Inactive

fix: stop actual ip update if ctx cancelled

db6775c

gbaranski temporarily deployed to Internal January 23, 2025 09:51 — with GitHub Actions Inactive

gbaranski requested a review from mariusSincovici January 23, 2025 09:52

fix: use a buffered channel for actual ip result

b3513e8

gbaranski temporarily deployed to Internal January 24, 2025 09:15 — with GitHub Actions Inactive

devzbysiu reviewed Jan 24, 2025

View reviewed changes

daemon/actual_ip_resolver.go Outdated Show resolved Hide resolved

fix: simpliy if else

60bb1b8

gbaranski requested a review from devzbysiu January 24, 2025 10:39

gbaranski temporarily deployed to Internal January 24, 2025 10:39 — with GitHub Actions Inactive

devzbysiu reviewed Jan 24, 2025

View reviewed changes

daemon/actual_ip_resolver.go Show resolved Hide resolved

devzbysiu reviewed Jan 24, 2025

View reviewed changes

daemon/actual_ip_resolver.go Show resolved Hide resolved

devzbysiu reviewed Jan 24, 2025

View reviewed changes

daemon/actual_ip_resolver.go Show resolved Hide resolved

gbaranski requested a review from devzbysiu January 24, 2025 13:37

gbaranski added 2 commits January 28, 2025 09:41

Merge branch 'main' into show-public-ip

84deb23

chore: regenerate protobuf

63ff929

gbaranski temporarily deployed to Internal January 28, 2025 08:41 — with GitHub Actions Inactive

fix: skip connect events that are attempts

6230a7b

gbaranski temporarily deployed to Internal January 28, 2025 11:14 — with GitHub Actions Inactive

test: add EventStatus to DataConnect

84a37d4

gbaranski temporarily deployed to Internal January 28, 2025 12:25 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 29, 2025 09:38 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show actual ip address of the user #734

Show actual ip address of the user #734

gbaranski commented Jan 8, 2025

Show actual ip address of the user #734

Are you sure you want to change the base?

Show actual ip address of the user #734

Conversation

gbaranski commented Jan 8, 2025