Add scroll to top button #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for zealous-spence-867386 ready! 🔨 Explore the source changes: ae91be3 🔍 Inspect the deploy log: https://app.netlify.com/sites/zealous-spence-867386/deploys/61cc2dbf48c7e90007db5fbd 😎 Browse the preview: https://deploy-preview-31--zealous-spence-867386.netlify.app/ |
franiakat
requested changes
Dec 28, 2021
| @@ -63,6 +64,7 @@ const ProblemsPage: FC = () => { | |||
| )) | |||
| )} | |||
| </Wrapper> | |||
| <ScrollToTopButton /> | |||
There was a problem hiding this comment.
In the end this won't be added on this page, but on ProblemDetailedPage, right? :)
There was a problem hiding this comment.
Of course, I put it here just to see and test the component :)
|
Two additional thoughts:
|
We can manage focus when the button will be used in the ProblemDetailedPage |
| ); | ||
| }; | ||
|
|
||
| export default ScrollToTopButton; |
franiakat
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create scroll to the button which will be added to the show problem page