-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade undici and make sure to always set its timeout fields #3665
Conversation
🦋 Changeset detectedLatest commit: c3327ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UPDATE I noticed that we weren't handling a timeout, which can happen when establishing a connection. It has to be handled in the agent, not per-request, so this fix is outdated. I implemented the proper fix in the HTTP provider, but I think this really calls for a WDYT @fvictorio ? |
is this pr not merged yet? |
Not yet, I'll try to prioritize it. |
This is the blocker for running fork node on a server. I always get:
on VPS, but I cannot reproduce it locally. |
Why is this one closed? I still have time out issue |
This PR also bumps the timeout used by hardhat-vyper to download the compiler. This tiemout wasn't used, but it happened to match unidici's default, and that wasn't enough.