Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade undici and make sure to always set its timeout fields #3665

Closed
wants to merge 8 commits into from

Conversation

alcuadrado
Copy link
Member

This PR also bumps the timeout used by hardhat-vyper to download the compiler. This tiemout wasn't used, but it happened to match unidici's default, and that wasn't enough.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: c3327ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nomiclabs/hardhat-vyper Patch
@nomiclabs/hardhat-etherscan Patch
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 11:19PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 11:19PM (UTC)

@alcuadrado
Copy link
Member Author

alcuadrado commented Feb 10, 2023

UPDATE

I noticed that we weren't handling a timeout, which can happen when establishing a connection. It has to be handled in the agent, not per-request, so this fix is outdated.

I implemented the proper fix in the HTTP provider, but I think this really calls for a @nomicfoundation/hardhat-utils package.

WDYT @fvictorio ?

@alcuadrado alcuadrado changed the title Upgrade undici and make sure to always set its timeout fields [WIP] Upgrade undici and make sure to always set its timeout fields Feb 11, 2023
@fvictorio fvictorio added status:ready This issue is ready to be worked on and removed status:triaging labels Mar 9, 2023
@hawkofsky
Copy link

is this pr not merged yet?

@fvictorio
Copy link
Member

Not yet, I'll try to prioritize it.

@0x8f701
Copy link

0x8f701 commented Jun 27, 2023

This is the blocker for running fork node on a server. I always get:

hardhat SocketError: other side closed

on VPS, but I cannot reproduce it locally.

@insider89
Copy link

Why is this one closed? I still have time out issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants