Fixed Duplicate Rule Update eslintrc.js #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate Rule for @typescript-eslint/return-await
zoeyTM
requested changes
Nov 21, 2024
| @@ -174,7 +174,7 @@ module.exports = { | |||
| }, | |||
| ], | |||
| "@typescript-eslint/unified-signatures": "error", | |||
| "@typescript-eslint/return-await": "error", | |||
| "@typescript-eslint/return-await": "error", // keeping this line only | |||
There was a problem hiding this comment.
This comment is unnecessary, please remove.
Suggested change
| "@typescript-eslint/return-await": "error", // keeping this line only | |
| "@typescript-eslint/return-await": "error", |
| @@ -216,8 +216,6 @@ module.exports = { | |||
| "no-new-func": "error", | |||
| "no-new-wrappers": "error", | |||
| "no-only-tests/no-only-tests": "error", | |||
| "no-return-await": "off", | |||
There was a problem hiding this comment.
This rule is not a duplicate, please add it back.
|
Thanks for the PR but after looking into it further, this change doesn’t seem to add much value to the project, and it looks like it might be part of automated activity. If that’s not the case, let us know, and we’ll take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Duplicate Rule for
@typescript-eslint/return-awaitIn the current ESLint configuration, the rule
@typescript-eslint/return-awaitis defined twice. This duplication leads to redundancy in the configuration, which can potentially cause confusion or make the configuration less maintainable.Solution:
I have removed the duplicate instance of the
@typescript-eslint/return-awaitrule. By keeping only one instance of the rule, we ensure that the configuration is more concise and easier to maintain, without any unnecessary repetition.Importance:
Removing the redundant rule is important because it prevents the configuration from being unnecessarily verbose and helps avoid potential issues with conflicting rule settings. A clean and precise configuration improves the readability and maintainability of the project’s code quality settings.