fix: add additional validation for global parameters #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default values for parameters masked the test cases for our global parameters feature. This commit adds additional tests for parameters without default values and enhances the validations to support Global Parameters as an option.
0eb6f90 to
04f2765
Compare
211f508 to
64aa809
Compare
If there is a parameter defined in Global parameters, and a different parameter defined at the module level, we were failing to find the global parameter. This has been fixed with a more explicit lookup in `resolveModuleParameter`. Two tests have been added to check module param lookup where a different global parameter exists, and global parameter lookup where a different module parameter exists.
64aa809 to
d5d44d6
Compare
Pull out the shared validation resolution code for module/global/default value resolution for module parameters.
kanej
commented
Nov 20, 2024
kanej
commented
Nov 20, 2024
packages/core/src/internal/validation/futures/validateArtifactContractAt.ts
Show resolved
Hide resolved
kanej
commented
Nov 20, 2024
zoeyTM
approved these changes
Nov 21, 2024
Merged
zoeyTM
pushed a commit
that referenced
this pull request
Nov 22, 2024
* fix: add additional validation for global parameters Default values for parameters masked the test cases for our global parameters feature. This commit adds additional tests for parameters without default values and enhances the validations to support Global Parameters as an option. * fix: use global params where other module params exist If there is a parameter defined in Global parameters, and a different parameter defined at the module level, we were failing to find the global parameter. This has been fixed with a more explicit lookup in `resolveModuleParameter`. Two tests have been added to check module param lookup where a different global parameter exists, and global parameter lookup where a different module parameter exists. * refactor: pull out shared validation code Pull out the shared validation resolution code for module/global/default value resolution for module parameters. Fixes #834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values for parameters masked the test cases for our global parameters feature.
This commit adds additional tests for parameters without default values and enhances the validations to support Global Parameters as an option.
TODO