Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle circular imports in verify loop #772

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Jun 3, 2024

resolves #770

simple fix for circular imports (or enormous import trees)

@zoeyTM zoeyTM requested a review from kanej June 3, 2024 03:34
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to do a manual run through of a verification against sepolia with a circular dependency structure.

We are attempting to use `any` and testing casting less.

remove superfluous type cast
@zoeyTM zoeyTM force-pushed the verify-circular-imports branch from 77933e0 to ccfdcca Compare June 3, 2024 15:38
@zoeyTM zoeyTM merged commit 5a6187c into development Jun 3, 2024
5 checks passed
@zoeyTM zoeyTM deleted the verify-circular-imports branch June 3, 2024 15:46
@zoeyTM zoeyTM mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RangeError: Maximum call stack size exceeded during verification on deployment
2 participants