Use readline in place of process.stdout #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring back the default sender test that previously failed due to tty issues.
kanej
reviewed
Dec 15, 2023
| // This test exists to ensure Ignition succeeds in a CI environment. | ||
| // This is a test that the UI, runs even in constrained terminal environments. | ||
| // It should always pass locally. | ||
| describe("Running deployment in CI environment", function () { |
kanej
approved these changes
Dec 15, 2023
alcuadrado
approved these changes
Dec 15, 2023
Merged
zoeyTM
added a commit
that referenced
this pull request
Dec 19, 2023
* use readline in place of process.stdout * add test for CI deployment * remove redundant CI task * test: bring back skipped test Bring back the default sender test that previously failed due to tty issues. * test: update test text --------- Co-authored-by: John Kane <john@kanej.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.stdoutin favor of native nodejsreadlinenpm testnowresolves #644