Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-sponsorship): post_dispatch #783

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

aliXsed
Copy link
Contributor

@aliXsed aliXsed commented Sep 13, 2023

on post_dispatch update pot_details and user…_details only partially

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (24fe1d8) 73.70% compared to head (936b486) 73.78%.

❗ Current head 936b486 differs from pull request most recent head 7e81116. Consider uploading reports for the commit 7e81116 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   73.70%   73.78%   +0.07%     
==========================================
  Files          47       47              
  Lines        8978     9005      +27     
==========================================
+ Hits         6617     6644      +27     
  Misses       2361     2361              
Files Changed Coverage Δ
pallets/sponsorship/src/lib.rs 94.39% <100.00%> (+0.15%) ⬆️
pallets/sponsorship/src/tests.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

simonsso
simonsso previously approved these changes Sep 13, 2023
Copy link
Contributor

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@ETeissonniere ETeissonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliXsed aliXsed merged commit 3ec4d27 into master Sep 13, 2023
@aliXsed aliXsed deleted the aliX/fix-sponsorship branch September 13, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants