Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max nft string length #715

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Increase max nft string length #715

merged 3 commits into from
Mar 14, 2023

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Mar 7, 2023

If the space allowed for a few more bytes IPFS:// urls could for instance be used.

@simonsso simonsso requested review from ETeissonniere, aliXsed, Hounsette and a team March 7, 2023 05:56
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #715 (829dcaf) into master (5121804) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   78.18%   78.18%           
=======================================
  Files          43       43           
  Lines        7596     7596           
=======================================
  Hits         5939     5939           
  Misses       1657     1657           
Impacted Files Coverage Δ
runtimes/eden/src/pallets_util.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aliXsed
aliXsed previously approved these changes Mar 12, 2023
Copy link
Contributor

@aliXsed aliXsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonsso I noticed for system parachains such as statemint they have gone all the way to "128" for this limit. So if it will be better future proof to go for 128 it would be still approved from my side.

@simonsso
Copy link
Contributor Author

@simonsso I noticed for system parachains such as statemint they have gone all the way to "128" for this limit. So if it will be better future proof to go for 128 it would be still approved from my side.

Let's do that.

@simonsso simonsso merged commit e6f47f1 into master Mar 14, 2023
@simonsso simonsso deleted the chore/uniques_string_limit branch March 14, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants