remove sass support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stoeffel
commented
Mar 1, 2018
•
a871c13 to
c3299b3
Compare
cachar
reviewed
Mar 1, 2018
There was a problem hiding this comment.
I grepped for sass and found it in a few more places-
In Parser/Ast.hs, does SourceType still need to have a Sass value? Then we could get rid of the Ast.Sass case over in DependencyTree.hs
Sass is also still mentioned in a couple of comments- on the readme, and in Parser.Require
| let wrapped = wrapModule fnName replacedContent | ||
| return $ Just wrapped | ||
| else return Nothing | ||
| lift $ do |
| @@ -76,12 +60,9 @@ mockConfig = | |||
| [] | |||
| ("." </> "test" </> "fixtures" </> "concat" </> "sources") | |||
| ("." </> "test" </> "fixtures" </> "concat" </> "sources") | |||
| [] | |||
There was a problem hiding this comment.
N/m it was the sass load paths in the old Config. I get it!
|
we should merge #43 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.