-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for partial compound index queries (closes #272) #278
Conversation
Kind a strange that Travis has not run ... |
Refactored to make compound-partial the strategy of last resort (to preserve backward compatibility) |
Could you please rebase your PR so that this PR is up-to-date and it will trigger the build now the CI is working again? |
2c686db
to
ab81945
Compare
ab81945
to
9ab0074
Compare
I've finally migrated the project to Github Actions and the build is green on I've already asked you to rebase your branch, and I'm sorry to ask you this again, but can you please rebase again your branch please ? |
9ab0074
to
cb44286
Compare
Rebased, with a small fix for Ruby2.2/Rails4. |
Sorry for the bad GH Actions configuration. It's now fixed (tested with my old fork of this project). Can you please rebase again ? It should trigger the build. |
a0c1d93
to
b128dff
Compare
LGTM thank you ! I think an update of the "Indexes" documentation page would be great in order to explain this index support extension. Could be just a sentence or more if you feel inspired 😉 |
Happy to add docs, now that I'm a reluctant expert in partial indexes. Is this the page to add that? https://github.com/NoBrainerORM/nobrainer.io/blob/master/docs/indexes.md |
Yes, that's the right page. |
No description provided.