Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partial compound index queries (closes #272) #278

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

CodeMonkeySteve
Copy link
Contributor

No description provided.

@zedtux
Copy link
Collaborator

zedtux commented Jul 6, 2021

Kind a strange that Travis has not run ...

@CodeMonkeySteve
Copy link
Contributor Author

Refactored to make compound-partial the strategy of last resort (to preserve backward compatibility)

@zedtux
Copy link
Collaborator

zedtux commented Sep 16, 2021

Could you please rebase your PR so that this PR is up-to-date and it will trigger the build now the CI is working again?

@zedtux
Copy link
Collaborator

zedtux commented May 31, 2022

I've finally migrated the project to Github Actions and the build is green on master.

I've already asked you to rebase your branch, and I'm sorry to ask you this again, but can you please rebase again your branch please ?

@CodeMonkeySteve
Copy link
Contributor Author

Rebased, with a small fix for Ruby2.2/Rails4.

@zedtux
Copy link
Collaborator

zedtux commented Jun 3, 2022

Sorry for the bad GH Actions configuration. It's now fixed (tested with my old fork of this project). Can you please rebase again ? It should trigger the build.

@zedtux
Copy link
Collaborator

zedtux commented Jun 11, 2022

LGTM thank you ! I think an update of the "Indexes" documentation page would be great in order to explain this index support extension. Could be just a sentence or more if you feel inspired 😉

@CodeMonkeySteve
Copy link
Contributor Author

Happy to add docs, now that I'm a reluctant expert in partial indexes. Is this the page to add that? https://github.com/NoBrainerORM/nobrainer.io/blob/master/docs/indexes.md

@zedtux
Copy link
Collaborator

zedtux commented Jun 12, 2022

Yes, that's the right page.

@zedtux zedtux merged commit 22b5f6b into NoBrainerORM:master Jun 15, 2022
@CodeMonkeySteve CodeMonkeySteve deleted the partial-index branch February 19, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants