-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements polymorphic associations (Closes #51) #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds automatically 2 new fields which should have an index. Doing so would raise the error:
This is completely normal and actually works like that with ActiveRecord when generating the migration script. |
e435d90
to
23de418
Compare
nviennot
requested changes
Mar 7, 2021
Thank you for all comments, I'll rework that soon. 🙇 |
23de418
to
90a9944
Compare
zedtux
commented
Apr 19, 2021
nviennot
reviewed
May 3, 2021
1411805
to
009c340
Compare
The following case doesn't seem to work: define_class :Metadata do
include NoBrainer::Document
end
define_class :Picture, Image do
include NoBrainer::Document
has_many :metadatas
end
define_class :Event do
include NoBrainer::Document
belongs_to :restaurant
has_many :photos, as: :imageable, class_name: 'Picture'
has_many :metadatas, through: :photos
end Trying to access
|
df8bc0e
to
4b2dccd
Compare
4b2dccd
to
5d5f281
Compare
57d98f4
to
1f58103
Compare
1f58103
to
3139e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the polymorphic associations, the same way ActiveRecord does.
belongs_to
now accepts thepolymorphic: true
andhas_many
/has_one
theas: :xxx
. Nobrainer adds 2 fields to the polymorphic model underthehood to store the foreign ID and Class then reuse them in query criteria.