verilog: cleanup & test

[drewrisinger]

Motivation for this change

Independently from #97513, I was working on cleaning up the package for ZHF, and didn't see that PR before merging.

This cleans up the derivation and adds self-tests along the lines of what is done in CI. https://github.com/steveicarus/iverilog/blob/07bbf4ce0f1aeb6dcfbabe239514c55822779fd9/.travis.yml

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[cole-h]

Diff LGTM. Maybe this should be 2 commits, though: verilog: cleanup, and verilog: add tests or something.

---

Result of nixpkgs-review pr 97613 1

4 packages failed to build:

• bluespec
• python27Packages.cocotb
• python37Packages.cocotb
• python38Packages.cocotb

13 packages built:

• glasgow (python38Packages.glasgow)
• mcy
• python37Packages.glasgow
• python37Packages.nmigen
• python37Packages.nmigen-boards
• python37Packages.nmigen-soc
• python38Packages.nmigen
• python38Packages.nmigen-boards
• python38Packages.nmigen-soc
• symbiyosys
• verilog
• vhd2vl
• yosys

[drewrisinger]

Diff LGTM. Maybe this should be 2 commits, though: verilog: cleanup, and verilog: add tests or something.

Fair. That's what I'd originally had but decided to squash it. Oh well. Will do

[drewrisinger]

Looks like build is failing on aarch64 due to floating point issues. Trying to get failure log. I think it's probably down to floating point errors in the br1029[a,b] tests: steveicarus/ivtest@8ef8d1c#diff-c4613803e21f6123e3fc555f27a80c13

[drewrisinger]

@GrahamcOfBorg build verilog

[drewrisinger]

@GrahamcOfBorg build verilog

[drewrisinger]

Failing on OfBorg due to OfBorg not evaluating due to not having #97807. Once OfBorg has that, I can track down the aarch64 build failure b/c I don't have a system to test that on.

[cole-h]

You could try asking for access to https://github.com/nix-community/aarch64-build-box (instructions in the README) -- unfortunately, ofborg deployment has been broken for a while, and we need Graham to fix it (who is unavailable on account of having a newborn to help take care of). It's been fixed, but to get three evaluators back, we need to deploy down to 1 evaluator, and then back up, which I don't currently have the time to do.

[drewrisinger]

Ok, my workaround is to disable the failing tests on aarch64. We'll see if OfBorg passes, but then we should be good to merge.

[drewrisinger]

@GrahamcOfBorg build verilog

[veprbl]

LGTM

[drewrisinger]

@veprbl are you saying you want me to backport these tests to the release-20.09 branch? That wasn't my original intention since it's building fine on that channel currently.

[veprbl]

@drewrisinger I thought we would want to run tests on release-20.09 as well, this would be nice if we need to do any fixes for verilog there.