-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove torch and related packages #83568
Conversation
@GrahamcOfBorg eval |
See NixOS#71888 for details.
@@ -23714,7 +23699,7 @@ in | |||
multimc = libsForQt5.callPackage ../games/multimc { }; | |||
|
|||
inherit (callPackages ../games/minetest { | |||
inherit (darwin) libiconv; | |||
inherit (darwin) libiconv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change, my emacs
replaced the tab character someone inserted into this file with the correct number of spaces.
]; | ||
|
||
src = fetchgit { | ||
url = "https://github.com/torch/distro"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're running version 0.0pre20160820
, which hasn't built in a long time, and upstream https://github.com/torch/distro/blob/master/README.md says, as of 3 years ago:
NOTE: Torch is not actively developed anymore and is in maintenance mode.
Btw I know nothing about torch, on #83567 I just cherry-picked @teto's cleanup. @bhipple on #83567 (comment) @worldofpeace said:
Do you know how to do that? If yes, could you do it for these packages? |
I think the idea is to check in something in the top-level So that if an unsuspecting user goes to try to do something like Is that right @worldofpeace? In this particular case I think we'd be fine with or without the aliases, since it's been broken for a long time and upstream died out years ago by the looks of it, so there probably won't be many users trying it out. |
Yes, that is spot on. Considering it has died out for years a silent removal could be ok. But in a general sense, the silent removal of anything usually upsets end users. |
We've removed the abandoned and broken torch project as part of NixOS#71888 This commit adds aliases for: - NixOS#81173 - NixOS#83568
We've removed the abandoned and broken torch project as part of NixOS#71888 This commit adds aliases for: - NixOS#81173 - NixOS#83568 (cherry picked from commit a80ed9f)
We've removed the abandoned and broken torch project as part of NixOS#71888 This commit adds aliases for: - NixOS#81173 - NixOS#83568 (cherry picked from commit a80ed9f)
See #71888 for details.
CC @NixOS/nixos-release-managers @nh2 @teto
ZHF: #80379
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)