-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: package set updates primarily for Python 3.8 support #71222
Conversation
@jonringer when pushing do so in batches, otherwise the evaluator runs often |
@GrahamcOfBorg eval |
im working on textacy, aiohttp, numpydoc, pybind11 right now. Just a heads up |
ok, thanks |
also, it seems like zope_exceptions is a common failing package for a lot of other packages..... it seems to build fine, looks like the site-packges installs fine... but none of the other packages seem to be able to import it |
probably a namespace package using the wrong namespace implementation |
that's what i thought as well, but if i load up the package in a pure nix-shell it seems to not be able to find it, even though it's on the PYTHONPATH |
but let's ignore it, it was broken already if I am correct. I recall having looked at it before |
I've also noticed that native bindings seem to be especially broken right now, similar to:
I'm assuming this is on the packages to update this? I also noticed that the other python versions have cython patches, but py38 does not... |
Correct, packages need to fix that for 3.8. |
84a1452
to
f7761c2
Compare
do you care for maintaining python2 support? |
I don't. I try to keep the core packages functioning but aside from that, no. It's really up to individual maintainers. Given that python2 is EOL by the time we release 20.03 it is even less relevant. |
That's what I thought, was just curious about freezing packages for python2, but I'll stop doing that as it is kind of time consuming |
also, it looks like wheel==41.4 is causing some issues:
related issue ansible/molecule#2350 |
About zope. I checked, and it appears they're migrating to the Don't know why they went straight for |
That's the correct approach for python2... but now i dont remember where I saw the error messages. |
i want to say the pkg_util is supposed to be python2 and python3 compatible: |
|
ruamel* dependencies no longer have correct namespacing for python2
setupwheels>=41.4 no longer collects the tests correctly
google.* namespace no longer works
python2 tries to import paste.deploy, which is no longer valid
The setup.py is no longer valid with setuptools>=41.4.0
2917e8b
to
c2b43fa
Compare
this also broke the package |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @