Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce closure size of Qt applications (backport) #69427

Merged
merged 10 commits into from
Sep 26, 2019
Merged

Reduce closure size of Qt applications (backport) #69427

merged 10 commits into from
Sep 26, 2019

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 25, 2019 •
edited
Loading

Motivation for this change

Fixes: #69272
See also: #69426

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ttuegel ttuegel added 6.topic: qt/kde 6.topic: closure size The final size of a derivation, including its dependencies labels Sep 25, 2019
@ttuegel ttuegel added this to the 19.09 milestone Sep 25, 2019
@ttuegel
Copy link
Member Author

ttuegel commented Sep 26, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from lukateras, 7c6f434c and lovek323 September 26, 2019 10:35
@ttuegel ttuegel merged commit 1943028 into NixOS:staging-19.09 Sep 26, 2019
@ttuegel ttuegel mentioned this pull request Sep 27, 2019
Merged
10 tasks
@lheckemann
Copy link
Member

For future reference: would be nice to have the commits cherry-picked with -x so that they contain a reference to the originals on master.

This was referenced Oct 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras Awaiting requested review from lukateras

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: closure size The final size of a derivation, including its dependencies 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.
2 participants
@ttuegel @lheckemann