libglvnd, ocl-icd, vulkan-loader: Remove addOpenGLRunpath where not needed. #64945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeded. For APIs that use driver config files, the config files should point to libraries using absolute paths, so `RUNPATH` should be unnecessary. It is still needed for `libGLX` because that does not use config files but the dispatch library receives just a vendor name from the X server.
10 tasks
|
I would like this to be reviewed. @ambrop72 I suggest checking who maintains this bit of code and cc them. |
Ralith
approved these changes
Aug 3, 2019
|
Looks good. I can't run a test build right now. A simple sanity check like "does glxgears run on an Intel system" should suffice; maybe I can run one on a weekend. |
matthewbauer
approved these changes
Aug 14, 2019
|
Sorry for the delay, I tested it for OpenCL and Vulkan on an NVIDIA machine. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For APIs that use driver config files, the config files should point to libraries using absolute paths, so
RUNPATHshould be unnecessary. It is still needed forlibGLXbecause that does not use config files but the dispatch library receives just a vendor name from the X server.Motivation for this change
Remove unneeded
RUNPATHfrom library. See the discussion #60985 (comment). This is is possible for NVidia after #62870 and #62859 were merged; open-source drivers already use absolute paths.Things done
Tested with drivers:
nvidia,nvidiaLegacy390:glxinfo,es2_info,vulkaninfoandopencl-infostill work, including 32-bit programs on 64-bit system.amdgpu:glxinfo,es2_infoandvulkaninfostill work, including 32-bit programs on 64-bit system (OpenCL does not work anyway).sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)