Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: 0.26.0 -> 0.26.6, 0.27.3 -> 0.27.4 #44625

Merged
merged 2 commits into from
Aug 19, 2018
Merged

libgit2: 0.26.0 -> 0.26.6, 0.27.3 -> 0.27.4 #44625

merged 2 commits into from
Aug 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 7, 2018

Security, misc fixes.

Unsure about the 0.26.x bump, wanted to at least see it's build-okay.

Have not tested the many dependencies.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

dtzWill added 2 commits August 7, 2018 11:16
@dtzWill
libgit2: 0.26.0 -> 0.26.6 (security, fixes)
8c78eee 
Don't know that there's a reason to keep the patch level
fixed at 0, optimistically bumping to latest (6).
@dtzWill
libgit2_0_27: 0.27.3 -> 0.27.4 (security)
cc02890 
https://github.com/libgit2/libgit2/releases/tag/v0.27.4
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

cannot build derivation '/nix/store/64rl9kp71fxryag1fdwgb27ci1dh245l-xar-1.6.1.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/3i19qsc862daphbhzlx913w9d70limyi-MacOS_SDK-10.10.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/rshcw2vvz6ann7wip94v20qdkldpmxwf-cmake-3.11.2.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/c94zbi1gr9l72ni3d52m5nkwq1hja2i0-python2.7-gyp-2015-06-11.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/lfpwsngsd90r6cmpri9lhglm19mlqk98-apple-framework-IOKit.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/zvssh0m5jan57adwzfgylywz0ipk3zml-http-parser-2.8.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/hs88cvilkm9yf0xzn9cbkl4pvvhgfy1c-apple-framework-Security.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/aks95mfc3hp8sz5yvb1x5w0mnri9iwf0-libgit2-0.26.6.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/yqz37nljmnv6hcnap5w2fh9agv2i31rb-libgit2-0.27.4.drv': 13 dependencies couldn't be built
error: build of '/nix/store/aks95mfc3hp8sz5yvb1x5w0mnri9iwf0-libgit2-0.26.6.drv', '/nix/store/yqz37nljmnv6hcnap5w2fh9agv2i31rb-libgit2-0.27.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

checking for ncursesw/ncurses.h... yes
checking ncursesw/term.h usability... yes
checking ncursesw/term.h presence... yes
checking for ncursesw/term.h... yes
configure: error: wide-char support enabled, but non-wide ncurses selects
builder for '/nix/store/bdlljg87swl1mrmrj3cyjnzzq7xilmz2-util-linux-2.32.1.drv' failed with exit code 1
cannot build derivation '/nix/store/srjdk2c62hjaw1h40sjvqchpz63mv4kn-http-parser-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3m2x6b9aq48n6rwikrwv2w4vy667ckfv-libgit2-0.26.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/z8sxwfn3vcrdl9y7l7hgy7z6g7h58syn-libgit2-0.27.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3m2x6b9aq48n6rwikrwv2w4vy667ckfv-libgit2-0.26.6.drv', '/nix/store/z8sxwfn3vcrdl9y7l7hgy7z6g7h58syn-libgit2-0.27.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

checking for ncursesw/ncurses.h... yes
checking ncursesw/term.h usability... yes
checking ncursesw/term.h presence... yes
checking for ncursesw/term.h... yes
configure: error: wide-char support enabled, but non-wide ncurses selects
builder for '/nix/store/y38b2kjmb6ysg74mh2qcir4vaflp0c5z-util-linux-2.32.1.drv' failed with exit code 1
cannot build derivation '/nix/store/w4s6hhmfm51x2c86sxlfaya00kpp8w6v-http-parser-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9fhbss8x9mnlvcf343ds0j08y07x3hfl-libgit2-0.26.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5c9f7csmrryxb4gn1w6qdx09j1k2h03k-libgit2-0.27.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5c9f7csmrryxb4gn1w6qdx09j1k2h03k-libgit2-0.27.4.drv', '/nix/store/9fhbss8x9mnlvcf343ds0j08y07x3hfl-libgit2-0.26.6.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Aug 8, 2018

(staging is on fire, don't mind the builders)

@dtzWill
Copy link
Member Author

dtzWill commented Aug 9, 2018

@GrahamcOfBorg build libgit2 libgit2_0_27

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

cannot build derivation '/nix/store/la6d1ls07vg98crl95s9dxlyf9rq9n5m-xar-1.6.1.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/r44wn8l70fnqljg3dvdmh5vybkzx2qqv-MacOS_SDK-10.10.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/b5xprj7m25rfwk7r3k28rpydkg8c8agh-cmake-3.11.2.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/jkn6g5cjnw4jm82604737wjn30sycg24-python2.7-gyp-2015-06-11.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/5fmhcppmvlic1hzfyvdsg4d6alpwpfvc-apple-framework-IOKit.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/25hx3qyw0yz8mi17xrr43f9srs2xfw2w-http-parser-2.8.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/ylagqn1hpvkk3j3sn9xpnaxybp2pcgig-apple-framework-Security.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/q22k8phgz06pkwyjnfxjvl6050a4f4mp-libgit2-0.26.6.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/6agnm995kqzmcsyx1vkicqpqidal18v5-libgit2-0.27.4.drv': 13 dependencies couldn't be built
error: build of '/nix/store/6agnm995kqzmcsyx1vkicqpqidal18v5-libgit2-0.27.4.drv', '/nix/store/q22k8phgz06pkwyjnfxjvl6050a4f4mp-libgit2-0.26.6.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

checking for ncursesw/ncurses.h... yes
checking ncursesw/term.h usability... yes
checking ncursesw/term.h presence... yes
checking for ncursesw/term.h... yes
configure: error: wide-char support enabled, but non-wide ncurses selects
builder for '/nix/store/mgns6vqj3c42ykml5cligxx57isy0jbx-util-linux-2.32.1.drv' failed with exit code 1
cannot build derivation '/nix/store/9mvv6q4sm2ppv91q4994l3gzfjwlwf62-http-parser-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/iichd6mbaaxak489i5d3falaykf8syxf-libgit2-0.26.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ppkq688mpxss228vrh8yww555kgsa2bi-libgit2-0.27.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/iichd6mbaaxak489i5d3falaykf8syxf-libgit2-0.26.6.drv', '/nix/store/ppkq688mpxss228vrh8yww555kgsa2bi-libgit2-0.27.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libgit2, libgit2_0_27

Partial log (click to expand)

checking for ncursesw/ncurses.h... yes
checking ncursesw/term.h usability... yes
checking ncursesw/term.h presence... yes
checking for ncursesw/term.h... yes
configure: error: wide-char support enabled, but non-wide ncurses selects
builder for '/nix/store/2q94zab05qlr3a8jny0a77h4fkfvr44d-util-linux-2.32.1.drv' failed with exit code 1
cannot build derivation '/nix/store/ffq4l5qff4pibvllqkvnjd4wypfc2nir-http-parser-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9jxbvz7l6rk2x222fhskl399kgns8k40-libgit2-0.26.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j3ag99khz395v5sn9q4759pgc6hb9gzi-libgit2-0.27.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9jxbvz7l6rk2x222fhskl399kgns8k40-libgit2-0.26.6.drv', '/nix/store/j3ag99khz395v5sn9q4759pgc6hb9gzi-libgit2-0.27.4.drv' failed

@vcunat
Copy link
Member

vcunat commented Aug 18, 2018

0.26.6 builds on 18.03 at least: #45298

@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 18, 2018
@vcunat vcunat merged commit cc02890 into NixOS:staging Aug 19, 2018
vcunat added a commit that referenced this pull request Aug 19, 2018
@vcunat
Merge #44625: libgit2* updates (security)
11f1893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzWill @GrahamcOfBorg @vcunat