Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixVersions.nix_2_26: Update and improve packaging #383508

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

nixVersions.nix_2_26: Update and improve packaging #383508

wants to merge 3 commits into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Feb 19, 2025 •
edited
Loading

Motivated primarily by

Changes

  • applies upstream improvements to the packaging expressions
  • implement the multi-output attribute interface (WIP, no tests yet)
    • remove uncontrolled package attributes in the process
      • of dubious utility
      • presence would depend on the output
      • unclear public interface

To do?

  • Improve meta attributes
  • Maybe not propagate the CLI?
  • Rewrite as normal multi-output derivation

For follow-up

  • Move makeOutputs to lib

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

roberth added a commit to roberth/nix that referenced this pull request Feb 20, 2025
@roberth
packaging: A few small improvements
a59d09e 
These are some small improvements gathered while working on
Nixpkgs packaging, NixOS/nixpkgs#383508.
They're low hanging fruit, while the Nixpkgs packaging is
still in flux (e.g. filesets aren't appreciated, nor is the
everything.nix multi-derivation package)

This makes the files more readily transferable.
@roberth roberth mentioned this pull request Feb 20, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roberth