Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama-cpp: fix rocmSupport #380550

Merged
merged 1 commit into from
Feb 9, 2025
Merged

llama-cpp: fix rocmSupport #380550

merged 1 commit into from
Feb 9, 2025

Conversation

duament
Copy link
Contributor

@duament duament commented Feb 9, 2025

fix #364708

As mentioned in that issue, rocm flag has been changed from GGML_HIPBLAS to GGML_HIP.

Tested on 7900 GRE (gfx1100)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@philiptaron philiptaron merged commit 4e15d13 into NixOS:master Feb 9, 2025
26 of 27 checks passed
@duament duament deleted the llama-cpp-rocm branch February 10, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llama-cpp uses the wrong cmake flag to build for ROCM
2 participants