-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensmtpd-extras: drop in favor of standalone filters #376913
Open
pks-t
wants to merge
9
commits into
NixOS:master
Choose a base branch
from
pks-t:pks-opensmtpd-table-passwd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
This PR adds or changes documentation
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Jan 26, 2025
pks-t
force-pushed
the
pks-opensmtpd-table-passwd
branch
from
January 26, 2025 08:28
089b369
to
12016f2
Compare
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-ldap, which is one of these new standalone filters to read login info from an LDAP server.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-mysql, which is one of these new standalone filters to read login info from a MySQL or MariaDB database.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-passwd, which is one of these new standalone filters to read login info from "passwd" files.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-postgres, which is one of these new standalone filters to read login info from a Postgres database.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-redis, which is one of these new standalone filters to read login info from a Redis instance. Building table-redis does not work out of the box: while the project correctly includes the hiredis include directory, the header itself is contained in a "hiredis/" subdirectory. Add a patch to fix this.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-socketmap, which is one of these new standalone filters to read login info from a Unix socket.
The opensmtpd-extra package has been deprecated in favor of standalone repositories for each of the filters. Introduce table-sqlite, which is one of these new standalone filters to read login info from an sqlite database.
The location of filters for OpenSMTPD has been changed to "libexec/smtpd". Adapt the service accordingly.
Upstream has archived the OpenSMTPD-extras repository with 82c49af (add deprecation notice, 2024-10-22). Instead, it has created a set of repositories, each containing one of the tables. The old tables aren't compatible anymore with recent OpenSMTPD versions due to changed protocols. Other extras, like the queues, don't have an alternative to the best of my knowledge. Furthermore, opensmtpd-extras doesn't even build anymore, furthermore indicating that there aren't any users of this package. Remove the "opensmtpd-extras" package and raise errors pointing to the new standalone tables. Add a release note.
pks-t
force-pushed
the
pks-opensmtpd-table-passwd
branch
from
January 26, 2025 08:44
12016f2
to
6766e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
This PR adds or changes documentation
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has archived the OpenSMTPD-extras repository with 82c49af (add
deprecation notice, 2024-10-22). Instead, it has created a set of
repositories, each containing one of the filters. The old filters aren't
compatible anymore with recent OpenSMTPD versions due to changed
protocols. Other extras, like the queues, don't have an alternative to
the best of my knowledge.
Furthermore, opensmtpd-extras doesn't even build anymore, furthermore
indicating that there aren't any users of this package.
This pull request imports the new filters and removes the "opensmtpd-extras" package accordingly.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.