Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ardour: bump c++ standard to c++17 #376823

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

aewatt95
Copy link
Contributor

@aewatt95 aewatt95 commented Jan 25, 2025

Fixes a build issue with boost

Additionally, C++11 will no longer be supported starting with Ardour 9.0

See this thread in the ardour forum for more information

Fixes #376099

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 25, 2025
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Nit: Full sentences in commit message body (not the subject line) should end with a dot.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2025
@aewatt95
Copy link
Contributor Author

Nit: Full sentences in commit message body (not the subject line) should end with a dot.

Ah, I missed that. Thank you. I will keep it in mind.

@bjornfor
Copy link
Contributor

Nit: Full sentences in commit message body (not the subject line) should end with a dot.

Ah, I missed that. Thank you. I will keep it in mind.

It's also easy to fix after the fact: git commit --amend && git push --force

Fixes a build issue with boost.

Additionally, C++11 will no longer be supported starting with Ardour 9.0.
@aewatt95 aewatt95 force-pushed the fix-ardour-cxx-version branch from df13d92 to e4fbae6 Compare January 25, 2025 23:58
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 26, 2025
@bjornfor bjornfor merged commit 1586c4b into NixOS:master Jan 26, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: ardour
4 participants