-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.llama-cpp-python: enable for Darwin #374698
Conversation
|
Tests are still crashing on darwin (at least in the sandbox). |
@GaetanLepage I've tried to rebuild with sandbox=true and sandbox=relaxed. It passed. I also tried to run nixpkgs-review against this PR. It passed. (The full command I tried is: Here is the log output from nixpkgs-review environment for the package.
Do you have a log for the failure that I could check? Thanks. Note: the segfault message from the comment suggests that it happens when calling to |
Thanks for the detailed feedback @booxter. Here are the complete logs: https://paste.glepage.com/raw/fish-bat-falcon |
OK I figured out what the cause of the failure on the builder machine is. The fix is ggerganov/llama.cpp#11441 ; I will backport it here later. |
|
@booxter please update commit message and PR title to correct attribute name, |
|
The |
For Darwin, there's no CUDA, hence run CUDA tests only for Linux. Also, if CUDA is used, we need gcc13 or lower, otherwise the build fails with: unsupported GNU version! gcc versions later than 13 are not supported! This change also updates passthru tests so that they are defined on linux only, since darwin has no CUDA anyway.
93bb916
to
8887951
Compare
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For Darwin, there's no CUDA, hence run CUDA tests only for Linux.
Also, if CUDA is used, we need gcc13 or lower, otherwise the build fails with:
unsupported GNU version! gcc versions later than 13 are not supported!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.