Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] niri: 0.1.10.1 -> 25.01 #373116

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 12, 2025

Manual backport of #373028

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
@kirillrdy
Copy link
Member

@getchoo does this meet backport criteria?

@sodiboo
Copy link
Contributor

sodiboo commented Jan 12, 2025

@getchoo does this meet backport criteria?

I think so? The criteria includes, for instance:

  • Version updates which include new functionality (but no breaking changes)

And this version doesn't contain breaking changes. It's only new functionality (and it's got a fairly big bit of functionality too: floating, which a lot of users have been wanting for a long time). I think that warrants a backport.

@kirillrdy kirillrdy merged commit 355833c into NixOS:release-24.11 Jan 12, 2025
23 checks passed
@getchoo getchoo deleted the backport-373028-to-release-24.11 branch January 12, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants