Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] rustup: Correct patchelf patch's use of create_dir #372872

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jan 11, 2025

Bot-based backport to release-24.11, triggered by a label in #372866.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

When updating a toolchain (rustup update stable) the previously
created wrapped ld.lld causes the new setup to fail.  This is
not ideal as it either is a spurious error, or it indicates
that the update has failed when it shouldn't have.

By using create_dir_all instead of create_dir, we avoid this problem.

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
(cherry picked from commit 375f840)
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2025
@FliegendeWurst FliegendeWurst merged commit 68e6b65 into release-24.11 Jan 11, 2025
27 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-372866-to-release-24.11 branch January 11, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants