Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpdocumentor: switch to buildComposerProject2 #372759

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 10, 2025

Manual backport of #368328

(cherry picked from commit bfd6e43)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(manual cherry picked from commit d88d2c2)
@drupol drupol merged commit de8b5ae into NixOS:release-24.11 Jan 10, 2025
18 of 19 checks passed
@drupol drupol deleted the backport-368328-to-release-24.11 branch January 10, 2025 22:11
@wolfgangwalther
Copy link
Contributor

I get this during nixpkgs-review:

error: hash mismatch in fixed-output derivation '/nix/store/d1gckkgn4b5a1vip6jfh9s1iindjgk0r-phpdocumentor-composer-repository-3.6.0.drv':
        likely URL: (unknown)
         specified: sha256-d+K/4xdhk0OlGmcjIRbMmTJJZjDSqfkvmynOl2thtmg=
            got:    sha256-+tkBDPfxnGmlHbgl6GN0Bxsh40Fawi948+O041wGXwc=

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

#facepalm ... how come ??!?!!

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

I got this on my side:

error: hash mismatch in fixed-output derivation '/nix/store/bibrzzvvpml16igzlf1rb5i9qvjkxw9b-phpdocumentor-composer-repository-3.6.0.drv':
         specified: sha256-Q1y18ERUs4iRd94JqBYVRNizR3v5MBTtItsxvGkrkyU=
            got:    sha256-PVaa0o8daoqXs8l3bF/Fsmtx3bdpO2uXTnR4tx8cUC4=
error: 1 dependencies of derivation '/nix/store/7phaf2iazqqj968gc9qgngvwnkbx5zza-phpdocumentor-3.6.0.drv' failed to build

@wolfgangwalther
Copy link
Contributor

Is this on master or on release-24.11?

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

On master branch:

❯ nix build .#phpdocumentor -L 
phpdocumentor> Running phase: unpackPhase
phpdocumentor> unpacking source archive /nix/store/30ryfv45bmdj5nc3xbqfdrgb41wgdvr7-source
phpdocumentor> source root is source
phpdocumentor> Running phase: patchPhase
phpdocumentor> Running phase: updateAutotoolsGnuConfigScriptsPhase
phpdocumentor> Running phase: configurePhase
phpdocumentor> Executing composerInstallConfigureHook
phpdocumentor> Setting COMPOSER_ROOT_VERSION to 3.6.0
phpdocumentor> Finished composerInstallConfigureHook
phpdocumentor> Running phase: buildPhase
phpdocumentor> Executing composerInstallBuildHook
phpdocumentor> Finished composerInstallBuildHook
phpdocumentor> Running phase: checkPhase
phpdocumentor> Executing composerInstallCheckHook
phpdocumentor> Finished composerInstallCheckHook
phpdocumentor> Running phase: installPhase
phpdocumentor> Executing composerInstallInstallHook
phpdocumentor> Creating symlink bin/phpdoc...
phpdocumentor> Creating symlink bin/phpdoc.php...
phpdocumentor> Finished composerInstallInstallHook
phpdocumentor> Running phase: fixupPhase
phpdocumentor> shrinking RPATHs of ELF executables and libraries in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> shrinking /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/phpdoc
phpdocumentor> checking for references to /build/ in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0...
phpdocumentor> patching script interpreter paths in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/githubaction: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc.php: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/tools/box: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/symfony/yaml/Resources/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/nikic/php-parser/bin/php-parse: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> rewriting symlink /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/phpdoc.php to be relative to /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> rewriting symlink /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/.phpdoc-wrapped to be relative to /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
❯ nix build .#phpdocumentor -L --rebuild
phpdocumentor> Running phase: unpackPhase
phpdocumentor> unpacking source archive /nix/store/30ryfv45bmdj5nc3xbqfdrgb41wgdvr7-source
phpdocumentor> source root is source
phpdocumentor> Running phase: patchPhase
phpdocumentor> Running phase: updateAutotoolsGnuConfigScriptsPhase
phpdocumentor> Running phase: configurePhase
phpdocumentor> Executing composerInstallConfigureHook
phpdocumentor> Setting COMPOSER_ROOT_VERSION to 3.6.0
phpdocumentor> Finished composerInstallConfigureHook
phpdocumentor> Running phase: buildPhase
phpdocumentor> Executing composerInstallBuildHook
phpdocumentor> Finished composerInstallBuildHook
phpdocumentor> Running phase: checkPhase
phpdocumentor> Executing composerInstallCheckHook
phpdocumentor> Finished composerInstallCheckHook
phpdocumentor> Running phase: installPhase
phpdocumentor> Executing composerInstallInstallHook
phpdocumentor> Creating symlink bin/phpdoc...
phpdocumentor> Creating symlink bin/phpdoc.php...
phpdocumentor> Finished composerInstallInstallHook
phpdocumentor> Running phase: fixupPhase
phpdocumentor> shrinking RPATHs of ELF executables and libraries in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> shrinking /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/phpdoc
phpdocumentor> checking for references to /build/ in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0...
phpdocumentor> patching script interpreter paths in /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/githubaction: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc.php: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/tools/box: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/symfony/yaml/Resources/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/nikic/php-parser/bin/php-parse: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/5vbvzfwnisybmm4kria458l0yk0sclb1-php-with-extensions-8.3.15/bin/php"
phpdocumentor> rewriting symlink /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/phpdoc.php to be relative to /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
phpdocumentor> rewriting symlink /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0/bin/.phpdoc-wrapped to be relative to /nix/store/j4f49345qfiplh7slr820b1z90k89l7c-phpdocumentor-3.6.0
~/C/N/nixpkgs > (~ (no description set) mnpztn 3ecbc) ❯   

Going to submit the hash change PR now.

@wolfgangwalther
Copy link
Contributor

Mine was on release-24.11 - so that needs an update as well.

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

=> #372987

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

Should be fixed on both branches now, can you please confirm?

@wolfgangwalther
Copy link
Contributor

Confirmed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants