Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] opam: fix opam sandboxing on nixos #372586

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Jan 10, 2025

Bot-based backport to release-24.11, triggered by a label in #363770.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

To make opam sandboxing (via bwrap) work on nixos, the following had been used
here:
  --set OPAM_USER_PATH_RO /run/current-system/sw/bin:/nix/
However, OPAM_USER_PATH_RO has been removed in opam 2.2.0, requiring a
new workaround: ocaml/opam@9b6370d
(Before this commit, executing `opam init` would display that sandboxing fails
with "bwrap: execvp sh: No such file or directory".)

- Removes outdated workarounds for ocp-build and argv0, cleans postInstall
- Fixes link to the changelog which was broken because of "with lib;"

(cherry picked from commit 5a51e70)
@GaetanLepage GaetanLepage merged commit 01738ef into release-24.11 Jan 10, 2025
20 of 24 checks passed
@GaetanLepage GaetanLepage deleted the backport-363770-to-release-24.11 branch January 10, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants