mlibc: init at 5.0.0-unstable-2025-01-05 #371092
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously gccWithoutTargetLibc was built with `langCC = false;`, which meant stdenvNoLibc had C++ support when not cross compiling or when the host platform toolchain is LLVM, but did not have C++ support when cross compiling for a non-Darwin and non-LLVM host platform. This patch fixes issues when cross compiling C++ packages built with stdenvNoLibc like LLVM libc and the mlibc package I'm (sanana) working on. Co-Authored-By: Artturin <Artturin@artturin.com> Co-Authored-By: Arsen Arsenović <arsen@aarsen.me>
Checking if openssl is a derivation requires evaluating stdenv.cc, which depends on mlibc when cross compiling to a mlibc platform, which depends on meson, which depends on Python. See previous commit 0070883 on why the recursion break happens in the Python expression.
In gcc, libsanitize is disabled because mlibc doesn't support libsanitize yet but upstream is working on it. Patches needed for gcc to support linux-mlibc targets are pulled from managarm's fork of gcc, patches only needed by managarm are not applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlibc is a portable C standard library by the managarm project. mlibc developers are interested in running a full linux distro on top of mlibc and in my opinion NixOS is a prime candidate. Having it in nixpkgs would also help developers using mlibc.
This is a draft PR because I need to build and test other architectures supported by mlibc on linux and there's a bug making mlibc's RTLD unable to find
libgcc_s.so.1through RPATH. So feel free to review even tho this is a draft. Static linking needs to be fixed. bash works when built with mlibc. #370683 needs to be merged before this is merged.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.