jack1: 0.125.0 -> 0.126.0 #370697
Merged
jack1: 0.125.0 -> 0.126.0 #370697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celt should be pinned to celt_0_7 for compatibility reasons. Specifically definition of celt_encoder_create, celt_decoder_create functions changed in laters of celt. This wasn't required in GCC_13 or older because the compiler would ignore it and print just an incompatible pointer to int conversion warning. Additionally version bumping of jack1 fixes another bug with port_rename_callback definition. This currently fixes build failure in master. Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
celt should be pinned to celt_0_7 for compatibility reasons.
Specifically definition of celt_encoder_create, celt_decoder_create functions changed in later versions of celt.
This wasn't required in GCC_13 or older because the compiler would ignore it and print just an incompatible pointer to int conversion warning.
Additionally version bumping of jack1 fixes another bug with port_rename_callback definition. This currently fixes build failure in master.
Closes #367870
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.