Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs30: add a patch to fix upstream bug 67916 #367296

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Dec 22, 2024

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67916

This PR reapplies #361947 to master. I also use builtins.path so that rebuilds are avoided when renaming the patch file.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 22, 2024
@ofborg ofborg bot requested review from jwiegley and lovek323 December 22, 2024 18:59
@jian-lin jian-lin merged commit f418dd0 into NixOS:master Dec 23, 2024
74 of 75 checks passed
@jian-lin jian-lin deleted the pr/emacs-fix-67916-again branch December 23, 2024 04:20
@nix-backports
Copy link

nix-backports bot commented Dec 23, 2024

Successfully created backport PR for release-24.05:

@nix-backports
Copy link

nix-backports bot commented Dec 23, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant