Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] mozc: use our protobuf (GCC 14 fix) #366868

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[staging-next] mozc: use our protobuf (GCC 14 fix) #366868

merged 2 commits into from
Dec 23, 2024

Conversation

FliegendeWurst
Copy link
Member

This also fixes the build for GCC 14.

Things done

@FliegendeWurst
mozc: devendor protobuf
87dba28 
This also fixes the build for GCC 14.
@FliegendeWurst FliegendeWurst changed the title [staging-next] mozc: devendor protobuf (GCC 14 fix) [staging-next] mozc: use our protobuf (GCC 14 fix) Dec 20, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 20, 2024
@ofborg ofborg bot requested review from pineapplehunter and gebner December 21, 2024 03:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 21, 2024
@pineapplehunter
Copy link
Contributor

I think this patch should be applied to pkgs/by-name/fc/fcitx5-mozc/package.nix too.

@FliegendeWurst
Copy link
Member Author

Yes, I caught that soon after this PR but forgot to push it. I'll add it here soon

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Dec 21, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 21, 2024
@vcunat vcunat merged commit de59a61 into NixOS:staging-next Dec 23, 2024
42 of 43 checks passed
scarlet-storm added a commit to scarlet-storm/flake that referenced this pull request Dec 23, 2024
@scarlet-storm
remove mozc hacks
8861b00 
NixOS/nixpkgs#366868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

@berberman berberman Awaiting requested review from berberman

@GovanifY GovanifY Awaiting requested review from GovanifY

@pineapplehunter pineapplehunter Awaiting requested review from pineapplehunter

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FliegendeWurst @pineapplehunter @vcunat @wegank