Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jdreaver email, remove as prowlarr maintainer #362954

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Update jdreaver email, remove as prowlarr maintainer #362954

merged 2 commits into from
Dec 9, 2024

Conversation

jdreaver
Copy link
Contributor

@jdreaver jdreaver commented Dec 7, 2024

Hello! This PR updates my email to my current email (me@davidreaver.com) and removes myself as the maintainer of prowlarr. I never actually used prowlarr for more than a couple days after adding the package to nixpkgs, and I don't want users to think I actually maintain it.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 7, 2024
@jdreaver
Copy link
Contributor Author

jdreaver commented Dec 9, 2024

Hey @fadenb @purcell @tie @corngood, sorry to bother you, but would you be able to help me approve this PR? I saw you tagged on a sonarr PR (#360592). I'm not sure who else to request a review from 😅

@fadenb
Copy link
Contributor

fadenb commented Dec 9, 2024

Approved it on Github.
I believe there is also some discourse thread for merge-ready PRs that gets regularly attention by folks that have permissions to merge. If there is no speedy reaction here you could try that approach 🙂

@corngood
Copy link
Contributor

corngood commented Dec 9, 2024

I think it should really be two commits:

maintainers: update jdreaver email
prowlarr: remove jdreaver as maintainer

Also since it's just metadata I'm inclined to backport it to 24.11, unless anyone objects.

@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 9, 2024
@jdreaver jdreaver force-pushed the jdreaver/maintainer-update branch from fc93ff2 to 1b7de0a Compare December 9, 2024 15:49
@jdreaver
Copy link
Contributor Author

jdreaver commented Dec 9, 2024

Thanks @fadenb and @corngood! Sorry about combining the commits. I've now broken this up into two commits with the commit messages that @corngood suggested.

@corngood corngood merged commit f5a5157 into NixOS:master Dec 9, 2024
21 of 22 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@corngood corngood corngood approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdreaver @fadenb @corngood