Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio-plugins.obs-ndi: fix deprecation errors #361864

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jshcmpbll
Copy link
Member

Deprecated functions void QDateTime::setTimeSpec(Qt::TimeSpec) and void QCheckBox::stateChanged(int) errors disabled.

Things done

  • Built on platform(s)
    • [x ] x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Deprecated functions `void QDateTime::setTimeSpec(Qt::TimeSpec)` and `void QCheckBox::stateChanged(int)` errors disabled.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2024
@tomodachi94 tomodachi94 linked an issue Dec 5, 2024 that may be closed by this pull request
@tomodachi94
Copy link
Member

Result of nixpkgs-review pr 361864 run on aarch64-linux 1

1 package built:
  • obs-studio-plugins.obs-ndi

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. There is a pending upstream PR at DistroAV/DistroAV#1151 which fixes the cause of the errors, but it looks like it's waiting on changes in OBS Studio, so I don't think it will be merged anytime soon.

@tomodachi94 tomodachi94 merged commit a772498 into NixOS:master Dec 5, 2024
20 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for release-24.05:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: obs-studio-plugins.obs-ndi
2 participants