azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #361077

Detegr · 2024-12-02T13:09:50Z

Things done

Add a 👍 reaction to pull requests you find important.

Detegr · 2024-12-02T13:27:06Z

I'm getting the following error locally:

       > Patchelfing microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg as microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg.47.nix-patched
       > patchelf: patchelf.cc:1095: void setSubstr(std::string&, unsigned int, const std::string&): Assertion `pos + t.size() <= s.size()' failed.

Made the pull request to make it reproducible and/or to see if it happens in the CI as well.

gepbird · 2024-12-02T16:49:36Z

I could reproduce that error:

       > Patching package microsoft.azure.functions.dotnetisolatednativehost/1.0.11
       > Patchelfing microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost as microsoft.azure.functions.dotnetisolatednativehost/1.0.11/co
ntentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.47.nix-patched
       > Patchelfing microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg as microsoft.azure.functions.dotnetisolatednativehost/1.0.1
1/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg.47.nix-patched
       > patchelf: patchelf.cc:1095: void setSubstr(std::string&, unsigned int, const std::string&): Assertion `pos + t.size() <= s.size()' failed.
       > /nix/store/w9yd8z7rxbnafzkkpmh9mznkql1cp45d-patch-nupkgs/bin/patch-nupkgs: line 14:    60 Aborted                 (core dumped) /nix/store/xjlvb8x7z3f5rxxswa3c6ghay74a58jm-patchelf-0.15.0/bin/patchelf --add-needed libicui18n.so --add-needed libicuuc.so --add-needed libz.so --add-needed libssl.so "$tmp"

My first instict was adding those libraries to buildInputs but that doesn't seem to help:

  buildInputs = [
    openssl
    zlib
    icu
  ];

gepbird · 2024-12-03T08:35:49Z

@NixOS/dotnet any idea about the aforementioned error?

GGG-KILLER · 2024-12-03T10:11:40Z

It seems like an issue with the way we detect what can be patchelf'd or not. I'll try to make a fix for it.

GGG-KILLER · 2024-12-04T21:58:20Z

@Detegr or @gepbird could either of you check if the changes in #361450 make it build properly for you now?

gepbird · 2024-12-04T22:40:37Z

@Detegr or @gepbird could either of you check if the changes in #361450 make it build properly for you now?

@GGG-KILLER I cherry picked the commit from your PR on top of this and unfortunately the build failed.

Build log

       > Running phase: fixupPhase                                                                                                                                                                                
       > Patching package microsoft.azure.functions.dotnetisolatednativehost/1.0.11                                                                           
       > patchelf: cannot find section '.interp'. The input file is most likely statically linked                                                             
       > Patchelfing microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost as microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.47.nix-patched
       > Patchelfing microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg as microsoft.azure.functions.dotnetisolatednativehost/1.0.11/contentFiles/any/any/workers/dotnet-isolated/bin/FunctionsNetHost.dbg.47.nix-patched
       > patchelf: patchelf.cc:1095: void setSubstr(std::string&, unsigned int, const std::string&): Assertion `pos + t.size() <= s.size()' failed.                                                                                                                                                                         
       > /nix/store/ng4s9mlk4phhnz4d59c14srfhrsv1cnz-patch-nupkgs/bin/patch-nupkgs: line 17:    72 Aborted                 (core dumped) /nix/store/xjlvb8x7z3f5rxxswa3c6ghay74a58jm-patchelf-0.15.0/bin/patchelf --add-needed libicui18n.so --add-needed libicuuc.so --add-needed libz.so --add-needed libssl.so "$tmp"

(going to sleep now)

GGG-KILLER · 2024-12-05T21:04:40Z

Ok, got it to compile with the latest changes in #361450, but now there's an error on the buildDotnetModule usage:

@nix { "action": "setPhase", "phase": "installPhase" }
Executing dotnetInstallHook
/nix/store/wlknwwx8f79lq8n07b0xh7ddjrrk191h-dotnet-sdk-8.0.404/share/dotnet/sdk/8.0.404/Current/SolutionFile/ImportAfter/Microsoft.NET.Sdk.Solution.targets(36,5): warning NETSDK1194: The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds. [/build/source/Azure.Functions.Cli.sln]
/nix/store/wlknwwx8f79lq8n07b0xh7ddjrrk191h-dotnet-sdk-8.0.404/share/dotnet/sdk/8.0.404/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.CrossTargeting.targets(31,5): error NETSDK1129: The 'Publish' target is not supported without specifying a target framework. The current project targets multiple frameworks, you must specify one of the following frameworks in order to publish: net8.0 [/build/source/test/Azure.Functions.Cli.Tests/Azure.Functions.Cli.Tests.csproj]
/nix/store/wlknwwx8f79lq8n07b0xh7ddjrrk191h-dotnet-sdk-8.0.404/share/dotnet/sdk/8.0.404/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.CrossTargeting.targets(31,5): error NETSDK1129: The 'Publish' target is not supported without specifying a target framework. The current project targets multiple frameworks, you must specify one of the following frameworks in order to publish: net8.0 [/build/source/src/Azure.Functions.Cli/Azure.Functions.Cli.csproj]

Adding the following line fixed it:

  dotnetFlags = [ "-p:TargetFramework=net8.0" ];

GGG-KILLER · 2024-12-09T02:52:15Z

PR fixing the bug you were encountering has been merged, if you could rebase and check it it works.

Detegr · 2024-12-10T07:40:25Z

Updated the PR with dotnetFlags set. Seems to be working now, thanks!

corngood · 2024-12-10T13:40:08Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361077

`x86_64-linux`

✅ 1 package built:

azure-functions-core-tools

gepbird

Thanks, your changes LGTM and the package works with .NET 8!

A few improvements and nits, but feel free to ignore if you think it's too unrealted:

run nixfmt on the package.nix
drop --replace as it is deprecated

-      --replace "CheckExitCode(\"/bin/bash" "CheckExitCode(\"${stdenv.shell}"
+      --replace-fail "CheckExitCode(\"/bin/bash" "CheckExitCode(\"${stdenv.shell}"

remove with lib; from meta
version checking

+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
+    versionCheckHook
+  ];

set meta.mainProgram
add an update script
remove rec next to buildDotnetModule

gepbird · 2024-12-10T13:58:19Z

pkgs/by-name/az/azure-functions-core-tools/package.nix

  src = fetchFromGitHub {
    owner = "Azure";
    repo = "azure-functions-core-tools";
    rev = version;
-    sha256 = "sha256-Ip1m0/l0YWFosYfp8UeREg9DP5pnvRnXyAaAuch7Op4=";
+    sha256 = "sha256-tUNiyvIjaIrdo6377IdXND7YgIk9zKkazDHV4kiWYa8=";


Suggested change

sha256 = "sha256-tUNiyvIjaIrdo6377IdXND7YgIk9zKkazDHV4kiWYa8=";

hash = "sha256-tUNiyvIjaIrdo6377IdXND7YgIk9zKkazDHV4kiWYa8=";

gepbird · 2024-12-10T13:59:24Z

pkgs/by-name/az/azure-functions-core-tools/package.nix

@@ -6,12 +6,12 @@
  dotnetCorePackages,
 }:
 let
-  version = "4.0.5455";
+  version = "4.0.6594";
  src = fetchFromGitHub {
    owner = "Azure";
    repo = "azure-functions-core-tools";
    rev = version;


See #355973

Suggested change

rev = version;

tag = version;

GGG-KILLER · 2024-12-10T15:29:14Z

I wouldn't ignore the nixfmt point nor the --replace-fail one. They're both important.

The others would be tolerable if not done (but should be done ideally), however without meta.mainProgram, lib.getExe and nix run may not work properly. But none of them are unrelated overall IMHO.

corngood · 2024-12-11T18:35:19Z

I wouldn't ignore the nixfmt point nor the --replace-fail one. They're both important.

The others would be tolerable if not done (but should be done ideally), however without meta.mainProgram, lib.getExe and nix run may not work properly. But none of them are unrelated overall IMHO.

This is all good stuff, but this is essentially a simple update PR, and I don't think it makes sense to block it.

Detegr · 2024-12-11T19:48:42Z

Fixed review comments. I had to left out version check as the software seems to report 4.0.1 for every 4.0.xxxx version 🤷

corngood · 2024-12-11T19:58:41Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361077

`x86_64-linux`

✅ 1 package built:

azure-functions-core-tools

gepbird · 2024-12-12T08:48:23Z

pkgs/by-name/az/azure-functions-core-tools/package.nix

  stdenv,
  fetchFromGitHub,
  buildDotnetModule,
  buildGoModule,
  dotnetCorePackages,
+  versionCheckHook,


Unused, but its not worth blocking on this. Unfortunate that upstream doesn't properly update their version

Suggested change

versionCheckHook,

nixpkgs-ci · 2024-12-13T18:15:31Z

Successfully created backport PR for release-24.11:

[Backport release-24.11] azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #364982

github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 2, 2024

gepbird mentioned this pull request Dec 2, 2024

.NET 6/7 are EOL #326335

Open

17 tasks

GGG-KILLER mentioned this pull request Dec 3, 2024

dotnetCorePackages.patchNupkgs: fix patchelf usage #361450

Merged

13 tasks

GGG-KILLER mentioned this pull request Dec 5, 2024

Call to --add-needed fails on .dbg files NixOS/patchelf#580

Open

Detegr force-pushed the azf-core-tools branch from 01c50bf to 31d76ad Compare December 10, 2024 07:40

gepbird self-requested a review December 10, 2024 10:47

corngood approved these changes Dec 10, 2024

View reviewed changes

corngood added the backport release-24.11 Backport PR automatically label Dec 10, 2024

gepbird approved these changes Dec 10, 2024

View reviewed changes

wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 10, 2024

ofborg bot requested a review from mdarocha December 11, 2024 04:50

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 11, 2024

corngood referenced this pull request Dec 11, 2024

dotnet-sdk/runtime/aspnetcore: 6.0 -> 8.0

bfaca46

azure-functions-core-tools: 4.0.5455 -> 4.0.6610

d748cb4

Detegr force-pushed the azf-core-tools branch from 31d76ad to d748cb4 Compare December 11, 2024 19:47

corngood approved these changes Dec 11, 2024

View reviewed changes

github-actions bot removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 11, 2024

gepbird approved these changes Dec 12, 2024

View reviewed changes

ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 12, 2024

corngood merged commit d98ac94 into NixOS:master Dec 13, 2024
38 of 39 checks passed

nixpkgs-ci bot mentioned this pull request Dec 13, 2024

[Backport release-24.11] azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #364982

Merged

1 task

This was referenced Dec 14, 2024

Update request: azure-functions-core-tools 4.0.5455 → 4.0.5611 #302640

Closed

azure-functions-core-tools: 4.0.5455 -> 4.0.5700 #310237

Closed

azure-functions-core-tools: 4.0.5455 #364653

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #361077

azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #361077

Detegr commented Dec 2, 2024 •

edited by corngood

Loading

Detegr commented Dec 2, 2024

gepbird commented Dec 2, 2024

gepbird commented Dec 3, 2024

GGG-KILLER commented Dec 3, 2024

GGG-KILLER commented Dec 4, 2024

gepbird commented Dec 4, 2024 •

edited

Loading

GGG-KILLER commented Dec 5, 2024 •

edited

Loading

GGG-KILLER commented Dec 9, 2024

Detegr commented Dec 10, 2024

corngood commented Dec 10, 2024

gepbird left a comment •

edited

Loading

gepbird Dec 10, 2024

gepbird Dec 10, 2024

GGG-KILLER commented Dec 10, 2024 •

edited

Loading

corngood commented Dec 11, 2024

Detegr commented Dec 11, 2024

corngood commented Dec 11, 2024

gepbird Dec 12, 2024

nixpkgs-ci bot commented Dec 13, 2024

	sha256 = "sha256-tUNiyvIjaIrdo6377IdXND7YgIk9zKkazDHV4kiWYa8=";
	hash = "sha256-tUNiyvIjaIrdo6377IdXND7YgIk9zKkazDHV4kiWYa8=";

azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #361077

azure-functions-core-tools: 4.0.5455 -> 4.0.6594 #361077

Conversation

Detegr commented Dec 2, 2024 • edited by corngood Loading

Things done

Detegr commented Dec 2, 2024

gepbird commented Dec 2, 2024

gepbird commented Dec 3, 2024

GGG-KILLER commented Dec 3, 2024

GGG-KILLER commented Dec 4, 2024

gepbird commented Dec 4, 2024 • edited Loading

GGG-KILLER commented Dec 5, 2024 • edited Loading

GGG-KILLER commented Dec 9, 2024

Detegr commented Dec 10, 2024

corngood commented Dec 10, 2024

nixpkgs-review result

x86_64-linux

gepbird left a comment • edited Loading

Choose a reason for hiding this comment

gepbird Dec 10, 2024

Choose a reason for hiding this comment

gepbird Dec 10, 2024

Choose a reason for hiding this comment

GGG-KILLER commented Dec 10, 2024 • edited Loading

corngood commented Dec 11, 2024

Detegr commented Dec 11, 2024

corngood commented Dec 11, 2024

nixpkgs-review result

x86_64-linux

gepbird Dec 12, 2024

Choose a reason for hiding this comment

nixpkgs-ci bot commented Dec 13, 2024

Detegr commented Dec 2, 2024 •

edited by corngood

Loading

gepbird commented Dec 4, 2024 •

edited

Loading

GGG-KILLER commented Dec 5, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

gepbird left a comment •

edited

Loading

GGG-KILLER commented Dec 10, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`